Bug 1666410

Summary:	Firefox-wayland draws menus off screen
Product:	[Fedora] Fedora	Reporter:	Bojan Smojver <bojan>
Component:	firefox	Assignee:	Martin Stransky <stransky>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	29	CC:	0xalen+redhat, anto.trande, bojan, gecko-bugs-nobody, jan.public, jhorak, john.j5live, jorti, kengert, pjasicek, rhughes, rstrode, samuel-rhbugs, sandmann, stransky
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-15 13:27:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1054334

Description Bojan Smojver 2019-01-15 18:25:00 UTC

Description of problem:
Bookmark menus drawn partially off (outside) screen with native Wayland FF.

Version-Release number of selected component (if applicable):
firefox-wayland-64.0.2-1.fc29.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. Customise toolbar by placing bookmarks icon to the left of the hamburger menu.
2. Make FF window big, so that there is just a big of empty space left.
3. Click on Bookmarks icon in the toolbar, hover over Bookmarks Toolbar with the mouse, watch part of the menu disappear off screen.

Actual results:
Menus partially displayed off screen

Expected results:
This works just fine with regular FF. Menus are simply drawn to the left (i.e. on screen).

Additional info:
No idea whether this is a GTK3 bug or not. The Mozilla bug says that stuff like this should be fixed with version 3.24 of GTK. I'm running gtk3-3.24.3-1.fc29.x86_64 and yet this is still happening (stable version does it too). So, opening this bug so that it can be properly tracked.

Comment 1 Bojan Smojver 2019-01-31 09:33:48 UTC

Still the same in firefox-65.0-1.fc29.x86_64.

Comment 2 Martin Stransky 2019-02-28 10:28:06 UTC

This happens when Firefox window is not maximized, correct? As I can't reproduce that in maximized state.

Comment 3 Bojan Smojver 2019-02-28 10:35:05 UTC

(In reply to Martin Stransky from comment #2)
> This happens when Firefox window is not maximized, correct? As I can't
> reproduce that in maximized state.

Correct.

Comment 4 Martin Stransky 2019-02-28 10:52:09 UTC

*** Bug 1673291 has been marked as a duplicate of this bug. ***

Comment 5 Martin Stransky 2019-03-15 13:27:56 UTC

Added to firefox-66.0-2 builds, it's in koji now.

Comment 6 Bojan Smojver 2019-03-15 13:39:48 UTC

(In reply to Martin Stransky from comment #5)
> Added to firefox-66.0-2 builds, it's in koji now.

Awesome. Thanks for chasing this. Looking forward to testing.

Comment 7 Bojan Smojver 2019-03-21 10:59:47 UTC

I just tried the firefox-66.0-6.fc29.x86_64 and it is better, but still doesn't quite work correctly. Many times the sub-menus don't really show when the mouse is over the bookmark folder. And some of the menus also still are outside of the screen.

Progress, for sure, but not quite there.

Comment 8 Martin Stransky 2019-03-21 11:05:48 UTC

(In reply to Bojan Smojver from comment #7)
> I just tried the firefox-66.0-6.fc29.x86_64 and it is better, but still
> doesn't quite work correctly. Many times the sub-menus don't really show
> when the mouse is over the bookmark folder. And some of the menus also still
> are outside of the screen.
> 
> Progress, for sure, but not quite there.

It needs a fix on mutter side - https://gitlab.gnome.org/GNOME/mutter/merge_requests/496

Also it's broken on multi-monitor setup - I'm working on it right now.

Comment 9 Bojan Smojver 2019-03-21 11:08:05 UTC

Thanks, your effort is very much appreciated!

Comment 10 Bojan Smojver 2019-03-23 05:16:26 UTC

BTW -9 is better again, almost completely solved. The only thing that still happens is that exit with mouse from the sub-menu will not close it and occasionally hovering will not open the sub-menu (both of which I'm guessing are mutter things that need fixing). So, thanks again!

Comment 11 Bojan Smojver 2019-03-31 08:51:19 UTC

And 66.0.1-4 is even better. I could not find anything wrong with the bookmark menus. They do behave differently than under X11, but that's to be expected, I guess.