Bug 166650

Summary:	libmusicbrainz is not enabled
Product:	[Fedora] Fedora	Reporter:	Sara Cavallari <sara.c>
Component:	amarok	Assignee:	Aurelien Bompard <gauret>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4	CC:	extras-qa, gilboad, ilya.konstantinov
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://buildsys.fedoraproject.org/logs/4/384-amarok-1.3-6.fc4/i386/
Whiteboard:
Fixed In Version:	fc4	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-11 20:59:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sara Cavallari 2005-08-24 12:09:15 UTC

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; it-IT; rv:1.7.10) Gecko/20050720 Fedora/1.0.6-1.1.fc4 Firefox/1.0.6

Description of problem:
I see, from the spec file, that libmusicbrainz is required for the build process,  but then isn't compiled in because of a (hidden) missing dependency. 
This is because amarok needs *both* libmusicbrainz and libtunepimp to enable musicbrainz support. The configure script doesn't explicitely warns about musicbrainz not being compiled in, so it's difficult to understand what the problem is. You can figure out reading the configure script though.


Version-Release number of selected component (if applicable):
amarok-1.3-6

How reproducible:
Always

Steps to Reproduce:
Run amarok. Musicbrainz support isn't enabled despite you have libmusicbrainz package installed.

Additional info:

To add support for musicbrainz you need libtunepimp(-devel) packages in the repository. Maybe you can borrow the spec file used at kde-redhat project.

Comment 1 Michael Schwendt 2005-08-24 12:16:19 UTC

Does libtunepimp still depend on the MAD mp3 decoder?

Comment 2 Sara Cavallari 2005-08-24 13:13:34 UTC

I didn't know that mp3 decoding was the cause of tunepimp not being built on
fedora extras. I'll investigate to see if it can disabled. It should not know
anything about decoding, except for perfomance purposes.

Comment 3 Sara Cavallari 2005-08-24 13:21:02 UTC

I don't have a test system without libmad.
Anyway, commenting the libmad test in configure to make it NOT to found it,
doesn't give an error, and just says 

checking for mad_version in -lmad... no
*
*  The MAD mp3 decoder is not installed. Please download
*  the decoder from http://www.mars.org/home/rob/proj/mpeg
*  to include MP3 TRM generation capabilities.
*

After that, the configure complete succefully. 
( config.status: creating Makefile and so what )

Comment 4 Michael Schwendt 2005-08-24 14:48:55 UTC

http://home.arcor.de/ms2002sep/tmp/libtunepimp-0.3.0-1.src.rpm
(that's the one I built when testing -- dropping BR libmad-devel is trivial)

Comment 5 Sara Cavallari 2005-09-10 00:40:39 UTC

So, are libtunepimp and musicbrainz going to be included in fedora extras?
I ask this because I see this bug status is still "new"

Comment 6 Ilya Konstantinov 2005-11-03 11:32:23 UTC

libmusicbrainz is included in Fedora (development version) but libtunepimp isn't.
If tunepimp can be built without MAD linkage:
1. Do we lose the ability to generate TRMs for MP3s or does generating TRMs
simply become slower?
2. If I later install a non-Fedora RPM of libtunepimp with MAD linkage, could
Amarok keep using it or would Amarok need to be relinked?

Comment 7 Sara Cavallari 2006-02-11 15:01:13 UTC

I see newer versions of amarok on fc4 have libmusicbrainz enabled (by using
libtunepimp). 
Please set this bug as closed, fixed or whatever, I don't know how to do it by
myself (yet).

Comment 8 Aurelien Bompard 2006-02-11 20:59:59 UTC

Thanks, closing.
(P.S.: to close bugs, set the status using the combobox at the bottom of this
page, in the "Bug Status Change" section)