Bug 166679

Summary: [RHEL4] gnome-terminal incorrectly propagates tab changing key presses to vte if it tab could not be changed
Product: Red Hat Enterprise Linux 4 Reporter: Bastien Nocera <bnocera>
Component: gnome-terminalAssignee: Behdad Esfahbod <behdad>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: jwest, tao
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: RHEL4U3NAK
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-06-07 05:47:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
gnome-terminal-dont-send-prev-next-keys-to-terminal-2.patch
none
gnome-terminal-dont-send-prev-next-keys-to-terminal-3.patch none

Description Bastien Nocera 2005-08-24 15:50:19 UTC 
Description of problem:
See upstream bug: http://bugzilla.gnome.org/show_bug.cgi?id=138609
When reaching the last or first tab in a gnome-terminal using Ctrl+PageUp/Down,
~5 gets printed on the terminal.

I am of the opinion that those keypresses should only be passed to the terminal
if there's no other tabs. If the key combination is needed for a particular
application, either no tabs should be used, or the keyboard shortcut should be
changed in the Edit->Keyboard shortcuts dialogue.

Version-Release number of selected component (if applicable):
gnome-terminal-2.7.3-1
Comment 1 Ray Strode [halfline] 2005-08-24 16:10:52 UTC 
Hi Bastien,

I agree.  Conditionally sending the key presses to vte depending on what tab the
user is on seems pretty broken.  If there are tabs then gnome-terminal should
just swallow the key presses even if it doesn't use them.

You want to work on fixing this?
Comment 2 Bastien Nocera 2005-08-26 14:52:41 UTC 
Patch pushed to the upstream bug.

Ray, could you comment on this patch?
Comment 3 Bastien Nocera 2005-09-07 15:42:12 UTC 
Created attachment 118565 [details]
gnome-terminal-dont-send-prev-next-keys-to-terminal-2.patch

The patch committed upstream.
Comment 18 RHEL Program Management 2006-08-31 23:16:03 UTC 
Product Management has reviewed and declined this request.  You may appeal this
decision by reopening this request.
Comment 21 Bastien Nocera 2006-09-25 13:26:49 UTC 
Created attachment 137050 [details]
gnome-terminal-dont-send-prev-next-keys-to-terminal-3.patch

To apply on top of attachment 118565 [details]