Bug 1666847

Summary:	Re-editing the tabs after failure doesn't reflect in gdeploy conf file.
Product:	[oVirt] cockpit-ovirt	Reporter:	SATHEESARAN <sasundar>
Component:	Gdeploy	Assignee:	Gobinda Das <godas>
Status:	CLOSED CURRENTRELEASE	QA Contact:	SATHEESARAN <sasundar>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	0.11.29	CC:	bugs, cakersq, godas
Target Milestone:	ovirt-4.3.1	Keywords:	Regression
Target Release:	---	Flags:	sasundar: ovirt-4.3? rule-engine: blocker+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	cockpit-ovirt-0.12.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1666714	Environment:
Last Closed:	2019-03-01 10:21:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Gluster	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1666714

Description SATHEESARAN 2019-01-16 18:07:24 UTC

+++ This bug was initially created as a clone of Bug #1666714 +++

Description of problem:
-----------------------------
In gluster deployment if deployment fails due to wrong configuration of the parameters and user tries to re-edit the configuration in any tab i.e hosts,FQDN,volumes and bricks ,it is not reflected in the generated gdeploy conf file which leads to failed deployment .Even if reload button is clicked no changes are reflected.


Version-Release number of selected component:
----------------------------------------------
rhvh-4.2.8.0-0.20190108
glusterfs-server-3.12.2-32.el7rhgs

How reproducible:
-----------------
Everytime

Steps to Reproduce:
--------------------
1.Login to cockpit UI and start gluster deployment.
2.Configure all tabs and deploy.
3.If any error encountered try to re-edit the tabs and check the gdeploy conf file.

Actual results:
-------------------
Changes are not reflected in gdeploy conf file.


Expected results:
----------------
Any changes made should be reflected in new gdeploy conf file.

--- Additional comment from Red Hat Bugzilla Rules Engine on 2019-01-16 16:58:07 UTC ---

This bug report has Keywords: Regression or TestBlocker.

Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release.

Please resolve ASAP.

--- Additional comment from SATHEESARAN on 2019-01-16 18:03:11 UTC ---

This defect is marked with 'Regresion' as the same functionality was working well with RHHI-V 1.5 (RHV 4.2.7) and is now broken with RHHI-V 1.5.z (RHV 4.2.8)

With this defect in place, if there are any errors, or wrong values provided, then the user had to close the cockpit deployment window and start the deployment from scratch

Comment 1 Red Hat Bugzilla Rules Engine 2019-01-16 18:07:26 UTC

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 Gobinda Das 2019-02-01 06:26:29 UTC

*** Bug 1671561 has been marked as a duplicate of this bug. ***

Comment 3 Jason H. 2019-02-05 11:22:08 UTC

Manuallying editing the GDeployConfig from the web interface results in the file in /var/lib/ovirt-hosted-engine-setup/gdeploy/gdeployConfig.conf being updated, but once deploy is pressed, the /var/lib/ovirt-hosted-engine-setup/gdeploy/gdeployConfig.conf file is overwritten, and the default one is used.

Comment 4 Sandro Bonazzola 2019-02-12 13:34:22 UTC

This bug has been fixed without targeting it to a milestone. Please target it so we'll know when we'll need to re-build the package.

Comment 5 Gobinda Das 2019-02-18 06:39:24 UTC

As we don't have 4.2 build, moving this to 4.3.1.
And this issue if fixed with https://gerrit.ovirt.org/#/c/97734/

Comment 6 SATHEESARAN 2019-02-26 08:44:52 UTC

Tested with cockpit-ovirt-dashboard-0.12.2 

1. Re-editing the values gets reflected in the gluster-ansible playbook

Comment 7 Sandro Bonazzola 2019-03-01 10:21:28 UTC

This bugzilla is included in oVirt 4.3.1 release, published on February 28th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.