Bug 1667592 (CVE-2019-5719)

Summary: CVE-2019-5719 wireshark: ISAKMP dissector crash in epan/dissectors/packet-isakmp.c
Product: [Other] Security Response Reporter: Laura Pardo <lpardo>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED WONTFIX QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: unspecifiedCC: mruprich
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: wireshark 2.6.6, wireshark 2.4.12 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-29 20:56:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1667593, 1686923    
Bug Blocks: 1667594    

Description Laura Pardo 2019-01-18 22:00:41 UTC
In Wireshark 2.6.0 to 2.6.5 and 2.4.0 to 2.4.11, the ISAKMP dissector could crash. This was addressed in epan/dissectors/packet-isakmp.c by properly handling the case of a missing decryption data block.


References:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15374
https://www.wireshark.org/security/wnpa-sec-2019-04.html

Upstream Patch:
https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5b02f2a9b8772d8814096f86c60a32889d61f2c

Comment 1 Laura Pardo 2019-01-18 22:00:51 UTC
Created wireshark tracking bugs for this issue:

Affects: fedora-all [bug 1667593]

Comment 3 Riccardo Schirone 2019-03-08 16:41:59 UTC
Function dissect_transform() in packet-isakmp.c has a NULL pointer dereference flaw. The `decr` parameter may be NULL, but it is dereferenced without any check, thus leading to a crash.