Bug 1667772

Hi Stefan,

Is Vicky still with IBM? She is the owner of the Fedora package. If she is still there, we should see about having her add Debora as an owner, and perhaps myself. I will see if I can find out how to migrate ownership if she is no longer there. I have pull requests open for f28, f29, and master that cleans up the problem of crypto not being linked and some other issues caught by covscan from when I was doing rhel8 work.

Actually, looking at it there is still a problem. $(LNLLIBS) being at the end of the rule in makefile.fedora:

diff -ur tss2-1234/utils/makefile.fedora tss2-1234-new/utils/makefile.fedora
--- tss2-1234/utils/makefile.fedora	2019-01-20 21:21:11.356819497 -0700
+++ tss2-1234-new/utils/makefile.fedora	2019-01-20 21:22:02.507096182 -0700
@@ -220,7 +220,7 @@
 # TSS shared library build
 
 $(LIBTSS): 	$(TSS_OBJS)
-		$(CC) $(LNFLAGS) $(LNLFLAGS) -Wl,-soname,$(LIBTSSSONAME) -o $(LIBTSSVERSIONED) $(TSS_OBJS) $(LNLLIBS)
+		$(CC) $(LNFLAGS) $(LNLFLAGS) $(LNLLIBS) -Wl,-soname,$(LIBTSSSONAME) -o $(LIBTSSVERSIONED) $(TSS_OBJS)
 		rm -f $(LIBTSSSONAME)
 		ln -sf $(LIBTSSVERSIONED) $(LIBTSSSONAME)
 		rm -f $(LIBTSS)

If I move it forward to where the flags are it links properly.

Disregard comment #2. I was looking at an old package build on my system. My earlier patch that is in the pull request does fix it. What I found 
before was that LNLLIBS = -lcrypto was commented out in makefile.fedora. So uncommenting that solved the problem.

(In reply to Jerry Snitselaar from comment #1)
> Hi Stefan,
> 
> Is Vicky still with IBM? She is the owner of the Fedora package. If she is
> still there, we should see about having her add Debora as an owner, and

I believe Debora has taken over for Vicky now. Let me send her an email.

This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.