Bug 1667839

Summary:	Enable CPUNodeDiscovery by default
Product:	Container Native Virtualization (CNV)	Reporter:	Martin Sivák <msivak>
Component:	Installation	Assignee:	Martin Sivák <msivak>
Status:	CLOSED ERRATA	QA Contact:	Irina Gulina <igulina>
Severity:	high	Docs Contact:
Priority:	high
Version:	1.4	CC:	cnv-qe-bugs, fdeutsch, fsimonce, guchen, ipinto, mgoldboi, msivak, ncredi, rhallise, rwsu, stirabos
Target Milestone:	---	Keywords:	EasyFix
Target Release:	2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	hyperconverged-cluster-operator-container-v2.0.0-20	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-24 20:15:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Sivák 2019-01-21 09:29:05 UTC

Description of problem:

The feature gate CPUNodeDiscovery needs to be enabled to allow VMs to request specific CPU model names (compatibility).


This is currently disabled to not accidentally block QE testing, but we would like to release 1.4 WITH the feature flag enabled by default once we confirm it works.

The feature gate can be added manually:

Add CPUNodeDiscovery to the kubevirt-config: 
$ oc edit configmap -n kubevirt kubevirt-config

Comment 3 Nelly Credi 2019-02-11 11:14:24 UTC

while we have seen that it is working, 
i think its a bit late to enable it. 
can we target to 2.0?

Comment 4 Fabian Deutsch 2019-02-11 11:15:26 UTC

Absolutely, 2.0 only. We already agreed to not have it in 1.4 enabled by default.

Comment 5 Israel Pinto 2019-05-13 10:12:55 UTC

last update: 
After installation of hco-bundle-registry:v2.0.0-10

# oc describe  cm kubevirt-config -n kubevirt-hyperconverged 
Name:         kubevirt-config 
Namespace:    kubevirt-hyperconverged 
Labels:       app=hyperconverged-cluster 
Annotations:  <none> 

Data 
==== 
feature-gates: 
---- 
DataVolumes,SRIOV,LiveMigration,CPUManager 
Events:  <none>

Comment 6 Martin Sivák 2019-05-13 12:34:00 UTC

Posted as https://github.com/kubevirt/hyperconverged-cluster-operator/pull/89

Comment 7 Richard Su 2019-05-21 00:07:01 UTC

Hi Martin, can this be moved to ON_QA? The PR was merged.

Comment 8 Martin Sivák 2019-05-21 06:37:35 UTC

Yes, but someone from the HCO team should fill in the fixed in version field..

Comment 11 errata-xmlrpc 2019-07-24 20:15:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1850