Bug 1668042

Summary:	Docker may not properly close hijacked streams
Product:	Red Hat Enterprise Linux 7	Reporter:	Robb Manes <rmanes>
Component:	docker	Assignee:	Antonio Murdaca <amurdaca>
Status:	CLOSED ERRATA	QA Contact:	atomic-bugs <atomic-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	7.6	CC:	amurdaca, dornelas, lsm5, lsu, pasik
Target Milestone:	rc	Keywords:	Extras
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	docker-1.13.1-93.gitb2f74b2.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-13 01:52:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1186913, 1647729

Description Robb Manes 2019-01-21 19:05:49 UTC

Description of problem:
As described in https://github.com/kubernetes/kubernetes/issues/61557, it is possible for docker/moby to hang when hijacking a connection with input as it never properly closes the connection at the end of the stream.

This is resolved in upstream moby here:

https://github.com/moby/moby/pull/36517/commits/37983921c90b468cafd3ba2ca2574fb81cafe5a7#diff-59ab7cc5bb1a636a4bc611d138984608R193

Version-Release number of selected component (if applicable):
It does not appear to be in the source of the latest release available [docker-1.13.1-88.git07f3374.el7]

How reproducible:
Every time


Steps to Reproduce:
1. Run a kubectl command that will utilize docker hijacking:

  # echo -n a | kubectl exec -i mypod cat

2. Observe hang

Actual results:
Command hangs instead of closing the stream

Expected results:
Docker should close hijacked streams with proper CloseWrite() calls

Additional info:
I have not been able to test this myself yet; I only observe that we don't appear to close the stream as the commit does in postHijacked().

Comment 1 Antonio Murdaca 2019-01-21 20:46:25 UTC

Backported here https://github.com/projectatomic/docker/commit/b2f74b220126bddbae585cfe2406498ced3ae065

Comment 5 errata-xmlrpc 2019-03-13 01:52:23 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0487