Bug 1668849

Summary: Server looses its name when Authentication settings are changed
Product: Red Hat CloudForms Management Engine Reporter: Ievgen Zapolskyi <izapolsk>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED CURRENTRELEASE QA Contact: Ievgen Zapolskyi <izapolsk>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: medium    
Version: 5.10.0CC: abellott, bmidwood, dmetzger, hkataria, izapolsk, lavenel, mpovolny, obarenbo, simaishi, yrudman
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.11.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.11.0.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1757789 (view as bug list) Environment:
Last Closed: 2019-12-13 14:54:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1757789    

Description Ievgen Zapolskyi 2019-01-23 17:17:31 UTC 
Description of problem:
When session timeout or authentication mode are changed in Configuration, server name is changed to empty string.

This affects many automation tests.

Version-Release number of selected component (if applicable):
5.10.0.32, 5.9.8.0

How reproducible:
100%

Steps to Reproduce:
1. deploy new appliance
2. Go to Configuration->Authentication tab
3. Change Session timeout value or Mode to External
4. Click Save
5. look at appearing alert or reopen Configuration and check server name in tree

Actual results:
Server name gets blank

Expected results:
Server name shouldn't become blank


Additional info:
Comment 2 Ievgen Zapolskyi 2019-01-24 14:43:24 UTC 
name is lost in rest as well after auth change.
Comment 3 Harpreet Kataria 2019-01-24 16:41:11 UTC 
Created a PR on UI side to not allow server name to be updated when changes are saved for Authentication tab

https://github.com/ManageIQ/manageiq-ui-classic/pull/5194


~Harpreet
Comment 11 CFME Bot 2019-02-13 22:57:47 UTC 
New commits detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/9585e66ed476e329202a29d2d0a7bd60c2ebc6bb
commit 9585e66ed476e329202a29d2d0a7bd60c2ebc6bb
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jan 24 11:37:49 2019 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Jan 24 11:37:49 2019 -0500

    Only update/save name of server record when on Settings/Server tab.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1668849

 app/controllers/ops_controller/settings/common.rb | 2 +-
 spec/controllers/ops_controller/settings/common_spec.rb | 12 +-
 2 files changed, 12 insertions(+), 2 deletions(-)


https://github.com/ManageIQ/manageiq-ui-classic/commit/5ced8d0d782e7db453eb56681a46ce342b0575e5
commit 5ced8d0d782e7db453eb56681a46ce342b0575e5
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jan 24 13:47:37 2019 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Jan 24 13:47:37 2019 -0500

    Addressed code climate warning.

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1668849

 app/controllers/ops_controller/settings/common.rb | 3 +-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 12 Ievgen Zapolskyi 2019-05-08 19:53:55 UTC 
Verified in 5.11.0.3