Bug 1669581

Summary: libvirtd crash when hotplug 'block' type 'lun' device disk without 'sgio' setting to guest
Product: Red Hat Enterprise Linux 7 Reporter: John Ferlan <jferlan>
Component: libvirtAssignee: John Ferlan <jferlan>
Status: CLOSED ERRATA QA Contact: yisun
Severity: unspecified Docs Contact:
Priority: high    
Version: 7.7CC: jdenemar, jomurphy, yalzhang
Target Milestone: rcKeywords: Automation, Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-4.5.0-11.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1666605 Environment:
Last Closed: 2019-08-06 13:14:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1666605    
Bug Blocks:    

Comment 3 John Ferlan 2019-01-25 17:31:21 UTC
I have a patch ready...

Comment 7 yisun 2019-04-26 03:36:33 UTC
Test with libvirt-4.5.0-15.virtcov.el7.x86_64 And PASSED

1. no sgio setting
[root@dell-per740-08 device]# lsscsi
[0:2:0:0]    disk    DELL     PERC H730P Adp   4.29  /dev/sda
[76:0:0:0]   disk    LIO-ORG  device.logical-  4.0   /dev/sdb


[root@dell-per740-08 ~]# cat disk
<disk device="lun" type="block">
    <source dev="/dev/sdb"/>
    <driver name="qemu" type="raw"/>
    <target bus="scsi" dev="sdb"/>
</disk>


[root@dell-per740-08 ~]# virsh start avocado-vt-vm1
Domain avocado-vt-vm1 started

[root@dell-per740-08 ~]# virsh attach-device avocado-vt-vm1 disk
Device attached successfully

[root@dell-per740-08 ~]# cat /sys/dev/block/*/device/unpriv_sgio
0
0

[root@dell-per740-08 ~]# virsh domblklist avocado-vt-vm1
Target     Source
------------------------------------------------
vda        /var/lib/avocado/data/avocado-vt/images/jeos-27-x86_64.qcow2
sdb        /dev/sdb




[root@dell-per740-08 ~]# virsh detach-device avocado-vt-vm1 disk
Device detached successfully



2. sgio=unfiltered
[root@dell-per740-08 ~]# cat disk
<disk device="lun" type="block" sgio="unfiltered">
    <source dev="/dev/sdb"/>
    <driver name="qemu" type="raw"/>
    <target bus="scsi" dev="sdb"/>
</disk>


[root@dell-per740-08 ~]# virsh attach-device avocado-vt-vm1 disk
Device attached successfully

[root@dell-per740-08 ~]# cat /sys/dev/block/*/device/unpriv_sgio
0
1

[root@dell-per740-08 ~]# virsh domblklist avocado-vt-vm1
Target     Source
------------------------------------------------
vda        /var/lib/avocado/data/avocado-vt/images/jeos-27-x86_64.qcow2
sdb        /dev/sdb


[root@dell-per740-08 ~]# virsh detach-device avocado-vt-vm1 disk
Device detached successfully

3. sgio=filtered
[root@dell-per740-08 ~]# cat disk
<disk device="lun" type="block" sgio="filtered">
    <source dev="/dev/sdb"/>
    <driver name="qemu" type="raw"/>
    <target bus="scsi" dev="sdb"/>
</disk>

[root@dell-per740-08 ~]# virsh attach-device avocado-vt-vm1 disk
Device attached successfully

[root@dell-per740-08 ~]# cat /sys/dev/block/*/device/unpriv_sgio
0
0

[root@dell-per740-08 ~]# virsh domblklist avocado-vt-vm1
Target     Source
------------------------------------------------
vda        /var/lib/avocado/data/avocado-vt/images/jeos-27-x86_64.qcow2
sdb        /dev/sdb

[root@dell-per740-08 ~]# virsh detach-device avocado-vt-vm1 disk
Device detached successfully

Comment 9 errata-xmlrpc 2019-08-06 13:14:35 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2294