Bug 1669664

Summary: Wrong pkgconfig file
Product: [Fedora] Fedora Reporter: Antonio T. (sagitter) <anto.trande>
Component: openbabelAssignee: Dominik 'Rathann' Mierzejewski <dominik>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 28CC: dominik, itamar, susi.lehtola
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openbabel-2.4.1-12.fc28 openbabel-2.4.1-16.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-08 02:29:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Antonio T. (sagitter) 2019-01-25 21:45:18 UTC
Description of problem:
openbabel-2.0.pc is wrong (see libdir):

$ cat /usr/lib64/pkgconfig/openbabel-2.0.pc
prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}//usr/lib64
includedir=${prefix}/include
pkgincludedir=${includedir}/openbabel-2.0

Name: Open Babel library
Description: libopenbabel
Version: 2.4.1
Libs: -L${libdir} -lopenbabel
Cflags: -I${pkgincludedir}
 

Version-Release number of selected component (if applicable):
openbabel-2.4.1-15 at least.

How reproducible:
Always.

Actual results:
Openbabel library's path unrecognizable.

Comment 1 Dominik 'Rathann' Mierzejewski 2019-01-26 08:30:56 UTC
You're right:

$ pkg-config --libs openbabel-2.0
-L/usr/usr/lib64 -lopenbabel 
$ rpm -q openbabel-devel
openbabel-devel-2.4.1-15.fc29.x86_64

Thanks for the report. A patch would be welcome. I'll try fix it sometime soon.

Comment 2 Dominik 'Rathann' Mierzejewski 2019-01-26 17:00:29 UTC
This affects F28+.

Comment 3 Antonio T. (sagitter) 2019-01-26 19:04:01 UTC
(In reply to Dominik 'Rathann' Mierzejewski from comment #1)
> You're right:
> 
> $ pkg-config --libs openbabel-2.0
> -L/usr/usr/lib64 -lopenbabel 
> $ rpm -q openbabel-devel
> openbabel-devel-2.4.1-15.fc29.x86_64
> 
> Thanks for the report. A patch would be welcome. I'll try fix it sometime
> soon.

Just add

sed -e 's|LIB_INSTALL_DIR|LIB_SUFFIX|g' -i openbabel-2.0.pc.cmake

in %prep section.

Comment 4 Antonio T. (sagitter) 2019-01-26 19:55:19 UTC
(In reply to Antonio Trande from comment #3)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #1)
> > You're right:
> > 
> > $ pkg-config --libs openbabel-2.0
> > -L/usr/usr/lib64 -lopenbabel 
> > $ rpm -q openbabel-devel
> > openbabel-devel-2.4.1-15.fc29.x86_64
> > 
> > Thanks for the report. A patch would be welcome. I'll try fix it sometime
> > soon.
> 
> Just add
> 
> sed -e 's|LIB_INSTALL_DIR|LIB_SUFFIX|g' -i openbabel-2.0.pc.cmake
> 
> in %prep section.

Sorry, i meant

sed -e 's|@LIB_INSTALL_DIR@|lib@LIB_SUFFIX@|g' -i openbabel-2.0.pc.cmake

Comment 5 Dominik 'Rathann' Mierzejewski 2019-01-27 10:21:08 UTC
I don't like using sed in %prep instead of a patch. It's fragile and will silently pass if it doesn't match anything. Thanks for your suggestion, I'll put it in a patch instead.

Comment 6 Dominik 'Rathann' Mierzejewski 2019-01-27 11:32:48 UTC
Ugh, one of the tests is failing on s390x on F29+. This will take a while.

Comment 7 Dominik 'Rathann' Mierzejewski 2019-01-27 11:40:48 UTC
For the record:

F29: https://koji.fedoraproject.org/koji/taskinfo?taskID=32284774
rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=32284807

Comment 8 Fedora Update System 2019-01-27 22:57:45 UTC
openbabel-2.4.1-12.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2ec314ac84

Comment 9 Fedora Update System 2019-01-27 22:57:49 UTC
openbabel-2.4.1-16.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-beefbbb99d

Comment 10 Fedora Update System 2019-01-28 01:02:34 UTC
openbabel-2.4.1-12.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2ec314ac84

Comment 11 Fedora Update System 2019-01-28 02:24:59 UTC
openbabel-2.4.1-16.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-beefbbb99d

Comment 12 Fedora Update System 2019-02-08 02:29:19 UTC
openbabel-2.4.1-12.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-02-08 03:20:25 UTC
openbabel-2.4.1-16.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.