Bug 1669942

Summary: The initContainer of etcd static pod "discovery" does not use the downstream image
Product: OpenShift Container Platform Reporter: Qin Ping <piqin>
Component: InstallerAssignee: Alex Crawford <crawford>
Installer sub component: openshift-installer QA Contact: Johnny Liu <jialiu>
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: medium    
Priority: medium CC: jialiu, wking
Version: 4.1.0   
Target Milestone: ---   
Target Release: 4.1.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-08 17:41:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Qin Ping 2019-01-28 06:24:55 UTC
Description of problem:
The initContainer of etcd static pod "discovery" does not use the downstream image

Version-Release number of the following components:
./openshift-install v4.0.0-0.148.0.0-dirty

release image: 4.0.0-0.nightly-2019-01-25-205123
CoreOS version: RHCOS 47.280

How reproducible:
Always

Steps to Reproduce:
1. Extract the openshift-installer from release image: 4.0.0-0.nightly-2019-01-25-205123
2. Override the release image to 4.0.0-0.nightly-2019-01-25-205123
3. Override the os image to RHCOS 47.280
4. Create OCP cluster
5. Check the images used

Actual results:
the initContainer of etcd static pod "discovery" does not use the downstream image
$ oc get pod -oyaml -n kube-system --config=test1/auth/kubeconfig 
...
    initContainers:
    - args:
      - run
      - --discovery-srv=qe-piqin2.qe.devcluster.openshift.com
      - --output-file=/run/etcd/environment
      - --v=4
      image: registry.svc.ci.openshift.org/openshift/origin-v4.0:setup-etcd-environment
      imagePullPolicy: IfNotPresent
      name: discovery
      resources: {}
      securityContext: {}
      terminationMessagePath: /dev/termination-log
      terminationMessagePolicy: File
      volumeMounts:
      - mountPath: /run/etcd/
        name: discovery
...

Expected results:
All the images of etcd static pod use the downstream image.

Additional info:

Comment 1 Alex Crawford 2019-02-20 22:25:58 UTC
This should have been fixed back in https://github.com/openshift/machine-config-operator/pull/343.

Comment 2 Johnny Liu 2019-02-21 09:09:41 UTC
Verified this bug with 4.0.0-0.nightly-2019-02-19-205011, and PASS.

 oc get pod -oyaml -n kube-system|grep initContainers -A 8
    initContainers:
    - args:
      - run
      - --discovery-srv=qe-jialiu3.qe.devcluster.openshift.com
      - --output-file=/run/etcd/environment
      - --v=4
      image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:f5ea54de3e1ac23cd55f6442724108996d17e8b1c56e08a3378a7b1b74965378
      imagePullPolicy: IfNotPresent
      name: discovery
--
    initContainers:
    - args:
      - run
      - --discovery-srv=qe-jialiu3.qe.devcluster.openshift.com
      - --output-file=/run/etcd/environment
      - --v=4
      image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:f5ea54de3e1ac23cd55f6442724108996d17e8b1c56e08a3378a7b1b74965378
      imagePullPolicy: IfNotPresent
      name: discovery
--
    initContainers:
    - args:
      - run
      - --discovery-srv=qe-jialiu3.qe.devcluster.openshift.com
      - --output-file=/run/etcd/environment
      - --v=4
      image: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:f5ea54de3e1ac23cd55f6442724108996d17e8b1c56e08a3378a7b1b74965378
      imagePullPolicy: IfNotPresent
      name: discovery

Comment 3 W. Trevor King 2019-02-27 06:20:34 UTC
v0.12.0 just missed including [1] (which landed in 71ace53):

$ oc adm release info --commits quay.io/openshift-release-dev/ocp-release:4.0.0-0.3 | grep machine-config-oper
  machine-config-controller                     https://github.com/openshift/machine-config-operator                       96228eb286a36944b8a729abeea0442ed73af776
  machine-config-daemon                         https://github.com/openshift/machine-config-operator                       96228eb286a36944b8a729abeea0442ed73af776
  machine-config-operator                       https://github.com/openshift/machine-config-operator                       96228eb286a36944b8a729abeea0442ed73af776
  machine-config-server                         https://github.com/openshift/machine-config-operator                       96228eb286a36944b8a729abeea0442ed73af776
$ git log --first-parent -2 --format='%ai %h %d %s' 71ace53
2019-01-31 18:31:45 +0100 71ace53  Merge pull request #343 from abhinavdahiya/controller_images
2019-01-29 23:09:22 +0100 96228eb  Merge pull request #352 from rphillips/fix/file_validation_for_overwritten_file

So [2] is the first release to contain the fix.

[1]: https://github.com/openshift/machine-config-operator/pull/343
[2]: https://github.com/openshift/installer/releases/tag/v0.13.0