Bug 1670002

Description of problem:
Having a smart variable with overriding rules like:

Prioritize attribute order:
atributeOne,attributeTwo
attributeTwo

then attributeTwo is taken with _higher_ priority than the compound one.

Thanks to tbrisker++, the cause is:

Sat6.3:
https://github.com/theforeman/foreman/blob/1.15-stable/app/services/classification/base.rb#L50

that is executed as:

[16] pry(main)> "domain,ip\r\ndomain,netmask\r\ndomain".index('domain')
=> 0

instead of proper code:

[17] pry(main)> "domain,ip\r\ndomain,netmask\r\ndomain".split.index('domain')
=> 2

Sat6.4 has the same bug in:
https://github.com/theforeman/foreman/blob/1.18-stable/app/services/classification/values_hash_query.rb#L64


Version-Release number of selected component (if applicable):
any


How reproducible:
100%


Steps to Reproduce:
1. Have a Host with a puppet class applied (e.g. access_insights_client).
2. For the class, override a parameter by having:

Prioritize attribute order:
domain,netmask
domain,hostgroup
os
domain
hostgroup

Specify matchers:
domain,netmask = (insert values from the Host)   => Value1
domain,hostgroup = (insert values from the Host) => Value2
os = (insert value from the Host)                => Value3
domain = (insert value from the Host)            => Value4

3.
Check YAML/ENC of the Host and find the overriden smart parameter value


Actual results:
The parameter value will be Value4, and domain attribute matcher applied


Expected results:
Value1 to be applied, and domain,netmask attribute matcher applied.


Additional info: