Bug 1670036

Summary:	FTBFS: a test tries to convert EOF to unsigned char
Product:	[Fedora] Fedora	Reporter:	Marek Kašík <mkasik>
Component:	gdcm	Assignee:	Ankur Sinha (FranciscoD) <sanjay.ankur>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	igor.raits, sanjay.ankur, sebp, sergio
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-26 01:22:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marek Kašík 2019-01-28 13:17:57 UTC

Description of problem:
Test in Testing/Source/Common/Cxx/TestString2.cxx tries to set EOF as delimiter for gdcm::String<>. This fails on  ppc64le, aarch64, s390x and armv7hl as the delimiter is char and it seems that char on these architectures is actually unsigned char, hence the "error: narrowing conversion of '-1' from 'int' to 'char'" error.
I'm not sure why it needs EOF as delimiter in a string but there seems to be these solutions to this:

1) don't run the test
2) don't use EOF as delimiter, use e.g. '\0' instead
3) change definition of the TDelimiter to int (+ a lot of other needed changes probably)

Comment 1 Ben Cotton 2019-08-13 19:36:22 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 31 development cycle.
Changing version to 31.

Comment 2 Sergio Basto 2019-09-14 04:31:58 UTC

https://src.fedoraproject.org/rpms/gdcm/pull-request/6 

I rebase my repo after add '\0' like suggested 

Thanks

Comment 3 Ankur Sinha (FranciscoD) 2019-09-16 10:30:08 UTC

Fixed in F32/rawhide now. We're working on F31 now.