Bug 1670387

Summary: update-crypto-policies reports success when called with invalid arguments
Product: [Fedora] Fedora Reporter: Christian Heimes <cheimes>
Component: crypto-policiesAssignee: Red Hat Crypto Team <crypto-team>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: crypto-team, nmavrogi, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-29 10:58:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Christian Heimes 2019-01-29 13:21:03 UTC 
Description of problem:
update-crypto-policies does not return an error code when it is called with invalid arguments. Invalid arguments should result in error code != 0.

Version-Release number of selected component (if applicable):
crypto-policies-20181026-1.gitd42aaa6.fc29.noarch


How reproducible:
always

Steps to Reproduce:
1. update-crypto-policies DEFAULT
2. echo $? 

Actual results:
output: 
usage: /usr/bin/update-crypto-policies --set [POLICY]
usage: /usr/bin/update-crypto-policies --show
usage: /usr/bin/update-crypto-policies --no-check
usage: /usr/bin/update-crypto-policies --is-applied
usage: /usr/bin/update-crypto-policies

exit code is 0

Expected results:
exit code is > 0

Additional info:
Comment 1 Tomas Mraz 2019-02-01 11:37:40 UTC 
Fixed in upstream repository. Now it will return exit code 2.
Comment 2 Fedora Update System 2019-02-11 09:38:20 UTC 
crypto-policies-20180211-1.gite3eacfc.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-436ecd5423
Comment 3 Fedora Update System 2019-02-12 02:50:06 UTC 
crypto-policies-20190211-2.gite3eacfc.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-436ecd5423
Comment 4 Fedora Update System 2019-02-13 02:47:19 UTC 
crypto-policies-20190211-2.gite3eacfc.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.