Bug 167113

Summary: CAN-2004-2392 libuser serious programming bugs
Product: Red Hat Enterprise Linux 2.1 Reporter: Josh Bressers <bressers>
Component: libuserAssignee: Miloslav Trmač <mitr>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: 2.1CC: cochranb, mjc, poelstra, rh-bugzilla, wtogami
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: impact=low,source=bugzilla,reported=20040406
Fixed In Version: RHSA-2005-770 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-10-22 14:29:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Relevant hunks of libuser-0.51.10 none

Description Josh Bressers 2005-08-30 15:25:21 UTC 
+++ This bug was initially created as a clone of Bug #120168 +++

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4.2)
Gecko/20040308

Description of problem:
During code review I could a number of serious programming bugs:

If there was a failure reading config data, the memory buffer was
taken to be valid.

On a read failure of /dev/urandom, buffer was taken to be valid. The
function could not indicate that a failure occurred or even retry if
errno == EINTR.

Upon a read failure, salt may be mostly 0's.

During unlock, a structure was being passed by value to a variadic
function.

length returned by read was being caught in an unsigned variable which
would later cause write to output 4294967295 bytes of data.

flcose was being passed a NULL pointer in many places.



Version-Release number of selected component (if applicable):
libuser-0.51.7-7.1.1

How reproducible:
Always

Steps to Reproduce:
Found during code review
    

Additional info:

I will attach a patch that fixes all of these issues. I did not review
prior versions to see if they are susceptible to all these problems.

-- Additional comment from linux_4ever on 2004-04-06 12:10 EST --
Created an attachment (id=99149)
Patch to fix all the problems listed above.

Please apply before fedora core 2 final.




This issue should also affect RHEL2.1

Please see the parent bug for more information.
Comment 3 Miloslav Trmač 2005-09-11 14:48:23 UTC 
Created attachment 118691 [details]
Relevant hunks of libuser-0.51.10
Comment 4 Red Hat Bugzilla 2005-10-11 15:24:20 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2005-770.html
Comment 5 Miloslav Trmač 2005-10-11 15:26:18 UTC 
(The above was RHEL2.1)