Bug 1671174

Description of problem:

The now-deprecated utils.run() function ran crm*, corosync*, and ccs* commands by their absolute path by prepending the appropriate binaries directory.

1011 # Run command, with environment and return (output, retval)
1012 # DEPRECATED, please use lib.external.CommandRunner via utils.cmd_runner()
1013 def run(
1014     args, ignore_stderr=False, string_for_stdin=None, env_extend=None,
1015     binary_output=False
1016 ):
...
1027     if command[0:3] == "crm" or command in ["cibadmin", "cman_tool", "iso8601"]:
1028         args[0] = settings.pacemaker_binaries + command
1029     elif command[0:8] == "corosync":
1030         args[0] = settings.corosync_binaries + command
1031     elif command == "ccs":
1032         args[0] = settings.ccs_binaries + command


The CommandRunner.run() method (called by `utils.cmd_runner().run()`) does not prepend the binaries directory and instead runs commands by their base name, forcing a search through the directories in the PATH environment variable.


Below is an example of execution using `pcs cluster status` (the cluster_status function still uses the deprecated utils.run) and `pcs status` (the full_status function uses utils.cmd_runner().run).

[root@fastvm-rhel-7-5-22 pcs]# pcs cluster status --debug | head -1
Running: /usr/sbin/crm_mon -1 -r

[root@fastvm-rhel-7-5-22 pcs]# pcs status --debug | head -1
Running: crm_mon --one-shot --inactive

--------------------

Version-Release number of selected component (if applicable):

pcs-0.9.165-6.el7.x86_64

--------------------

How reproducible:

Always

--------------------

Steps to Reproduce:
1. Run `pcs cluster status --debug`. The cluster_status function uses utils.run.

2. Run `pcs status --debug`. The full_status function uses utils.cmd_runner().run.

--------------------

Actual results:

`pcs cluster status` calls /usr/sbin/crm_mon (absolute path).
`pcs status` calls crm_mon (relative path or base name).

--------------------

Expected results:

Both commands call /usr/sbin/crm_mon (absolute path).

--------------------

Additional info:

This can interfere with certain privilege escalation methods. One customer escalates user privileges via the suexec command provided by BoKS. The root environment is not getting set, so `crm_mon` is not found without an absolute path.