Bug 1671741

Summary: Review Request: perl-Parse-MIME - Parse MIME types, match against media ranges
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Parse-MIME-1.005-1.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-06 15:22:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-02-01 14:08:40 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Parse-MIME/perl-Parse-MIME.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Parse-MIME/perl-Parse-MIME-1.005-1.fc30.src.rpm
Description:
This Perl module provides basic functions for handling MIME types. It can handle
matching MIME types against a list of media ranges as specified in RFC 2616.

Fedora Account System Username:
Comment 1 Jitka Plesnikova 2019-02-05 16:04:44 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Parse-MIME-1.005-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Exporter)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(:VERSION) >= 5.6.0
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires
FIX: Please add 'perl(strict)' and 'perl(warnings)', it is not found by
     generators.

$ rpm -qp --provides perl-Parse-MIME-1.005-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Parse::MIME) = 1.005
      1 perl-Parse-MIME = 1.005-1.fc30
Binary provides are Ok.

$ rpmlint ./perl-Parse-MIME*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct all 'FIX' issue.

Otherwise the package looks good.
Approved
Comment 2 Gwyn Ciesla 2019-02-06 14:24:38 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Parse-MIME
Comment 3 Petr Pisar 2019-02-06 15:22:45 UTC 
Thank you for the review and the repository. I listed the nondetected dependencies.