Bug 1671768

Summary:	Review Request: perl-URI-Query - Class providing URI query string manipulation
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-URI-Query-0.16-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-06 15:41:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-02-01 15:07:40 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-URI-Query/perl-URI-Query.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-URI-Query/perl-URI-Query-0.16-1.fc30.src.rpm
Description:
URI::Query provides simple URI query string manipulation, allowing you to
create and manipulate URI query strings from GET and POST requests in web
applications. This is primarily useful for creating links where you wish to
preserve some subset of the parameters to the current request, and potentially
add or replace others. Given a query string this is doable with regular
expressions, of course, but making sure you get the anchoring and escaping
right is tedious and error-prone - this module is simpler.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-02-06 11:07:54 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-URI-Query-0.16-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Clone)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(overload)
      1 perl(parent) 
      1 perl(strict)
      1 perl(URI::Escape)
      1 perl(vars)
      1 perl(:VERSION) >= 5.5.30
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1 
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-URI-Query-0.16-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(URI::Query) = 0.16
      1 perl-URI-Query = 0.16-1.fc30
Binary provides are Ok.

$ rpmlint ./perl-URI-Query*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-02-06 14:34:04 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-URI-Query

Comment 3 Petr Pisar 2019-02-06 15:41:09 UTC

Thank you for the review and the repository.