Bug 1672283
| Summary: | rpm-ostree install <pkg> wrongly said "success" on failure deployment | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Victor Toso <victortoso> |
| Component: | ostree | Assignee: | Jonathan Lebon <jlebon> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 29 | CC: | dustymabe, jlebon, jonathan, miabbott, rfairley, tagoh, walters |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ostree-2019.2-1.fc30 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-04-29 01:41:49 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Victor Toso
2019-02-04 13:07:29 UTC
The actual error here is: > During /etc merge: Reading modified config file: fstatat(cups/ppd/AMS_Canon_Colour.ppd): No such file or directory The fact that `rpm-ostree install` didn't error out is unrelated. (The error that occurred in fact happened at `systemctl reboot` time, not at `rpm-ostree install` time. See https://github.com/ostreedev/ostree/pull/1503 and https://github.com/projectatomic/rpm-ostree/issues/40 for background). Re. `meson` specifically, note that the pattern we try to encourage on Silverblue is to have all your development tools in a container and keep the base OS minimal. The less things there are, the more reliable critical operations like booting, rebooting, and upgrading are. See http://www.projectatomic.io/blog/2018/02/fedora-atomic-workstation/ for some more context there. I'm going to close this as NOTABUG, but feel free to reopen if I misunderstood the intent. (Though note we much prefer keeping issues upstream! :)) I think we could do better to try to ensure more services are fully shut down before starting `ostree-finalize-staged.service`. Maybe there's a different shutdown target or ordering we could use there. I'm facing same issue here. so how can I recover that error to make things operational successfully? doing `systemctl restart ostree-finalize-staged` works as workaround to apply changes though, I want a solution not a workaround. > I'm facing same issue here.
What does `journalctl -b -1 -u ostree-finalize-staged.service` say? A similar cups issue?
(In reply to Jonathan Lebon from comment #4) > What does `journalctl -b -1 -u ostree-finalize-staged.service` say? A > similar cups issue? Yes, same. Jan 10 16:18:48 localhost.localdomain systemd[1]: Stopping OSTree Finalize Staged Deployment... Jan 10 16:19:00 localhost.localdomain ostree[8152]: Finalizing staged deployment Jan 10 16:19:06 localhost.localdomain ostree[8152]: Copying /etc changes: 22 modified, 0 removed, 113 added Jan 10 16:19:06 localhost.localdomain ostree[8152]: error: During /etc merge: Reading modified config file: fstatat(cups/ppd/HKG_35F_Pearl.ppd): No such file or directory Jan 10 16:19:06 localhost.localdomain systemd[1]: ostree-finalize-staged.service: Control process exited, c ode=exited status=1 Jan 10 16:19:06 localhost.localdomain systemd[1]: ostree-finalize-staged.service: Failed with result 'exit- code'. Jan 10 16:19:06 localhost.localdomain systemd[1]: Stopped OSTree Finalize Staged Deployment. -- Reboot -- This is likely fixed by https://github.com/ostreedev/ostree/pull/1840. Will re-open this bug to track that patch making it into the stable repos. Aha. I got the point. indeed, no error happened if I do `systemctl stop cups` prior to reboot. so yeah, that fix should works. I'm looking forward to see it is released soon. ostree-2019.2-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e42181e4da ostree-2019.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e42181e4da ostree-2019.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. |