Bug 1672693

Summary: Custom button attribute override message
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: AutomateAssignee: drew uhlmann <duhlmann>
Status: CLOSED ERRATA QA Contact: Nikhil Dhandre <ndhandre>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.0CC: duhlmann, mkanoor, ndhandre, obarenbo, smallamp, tfitzger
Target Milestone: GAKeywords: ZStream
Target Release: 5.10.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.1.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1651099 Environment:
Last Closed: 2019-03-06 09:50:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1651099    
Bug Blocks:    
Attachments:
Description Flags
verification none

Comment 2 Satoe Imaishi 2019-02-05 23:12:04 UTC
Backported to Hammer branch:

commit b8ec07a2fac279d9e3f5e40c3061df85e7055188
Author: Greg McCullough <gmccullo>
Date:   Tue Jan 15 16:15:32 2019 -0500

    Merge pull request #287 from d-m-u/fixing_message_thing
    
    Don't overwrite message in create_automation_object
    
    (cherry picked from commit f38c83c12af9154651f3f18f6febf2a762003cd9)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672693

Comment 3 CFME Bot 2019-02-13 01:54:34 UTC
New commit detected on ManageIQ/manageiq-automation_engine/hammer:

https://github.com/ManageIQ/manageiq-automation_engine/commit/b8ec07a2fac279d9e3f5e40c3061df85e7055188
commit b8ec07a2fac279d9e3f5e40c3061df85e7055188
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Jan 15 16:15:32 2019 -0500
Commit:     Greg McCullough <gmccullo>
CommitDate: Tue Jan 15 16:15:32 2019 -0500

    Merge pull request #287 from d-m-u/fixing_message_thing

    Don't overwrite message in create_automation_object

    (cherry picked from commit f38c83c12af9154651f3f18f6febf2a762003cd9)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1672693

 lib/miq_automation_engine/engine/miq_ae_engine.rb | 1 -
 spec/miq_ae_engine_spec.rb | 9 +
 2 files changed, 9 insertions(+), 1 deletion(-)

Comment 4 Nikhil Dhandre 2019-02-18 10:04:01 UTC
Created attachment 1535878 [details]
verification

It works fine as per BZ steps.

Comment 6 Tina Fitzgerald 2019-02-18 15:20:09 UTC
Hi Nikhil,

It looks there's a difference in what was specified between simulate and the custom button execution:

The button execution has YTALE as the message;
[----] I, [2019-02-18T04:52:14.989631 #9814:51cf5c]  INFO -- : Followed  Relationship [miqaedb:/System/custom_request/instance_1#YTALE]
[----] I, [2019-02-18T04:52:14.990176 #9814:51cf5c]  INFO -- : Followed  Relationship [miqaedb:/System/Request/Call_Instance_With_Message#create]

Simulate does not have the message specified(or has create as the message)
[----] I, [2019-02-18T04:51:47.631004 #10135:fc295c]  INFO -- : Followed  Relationship [miqaedb:/System/custom_request/instance_1#create]
[----] I, [2019-02-18T04:51:47.631902 #10135:fc295c]  INFO -- : Followed  Relationship [miqaedb:/System/Request/Call_Instance_With_Message#create]


Using the attribute section of simulate, you can specify the key: message with value: YTALE which should make a difference in the log output.

Let me know if you have any questions.

Thanks,
Tina

Comment 8 errata-xmlrpc 2019-03-06 09:50:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0453