Bug 1672753

Summary:	[RFE] [machines] Cannot create additional network device on cockpit
Product:	Red Hat Enterprise Linux 8	Reporter:	Javier Coscia <jcoscia>
Component:	cockpit-appstream	Assignee:	Martin Pitt <mpitt>
Status:	CLOSED ERRATA	QA Contact:	YunmingYang <yunyang>
Severity:	low	Docs Contact:	Lucie Vařáková <lmanasko>
Priority:	medium
Version:	8.0	CC:	lmanasko, mmarusak, mtessun, qiyuan, skobyda, usurse, xchen
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	8.2	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	The Virtual Machines page now supports creation and removal of virtual network interfaces. Screenshot: https://cockpit-project.org/blog/cockpit-203.html	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 15:42:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Javier Coscia 2019-02-05 19:04:11 UTC

Description of problem:

After or while creating a VM through cockpit UI, user cannot create an 
additional vNIC 

Version-Release number of selected component (if applicable):

cockpit-machines-184-1.el8.noarch

How reproducible:

100%

Steps to Reproduce:
1. Cockpit > Virtual Machines > Create VM



Actual results:

- There is no option to add another vNIC interface other than the `default` one

Expected results:

- User should be able to create additional vNIC interfaces while creating the 
VM or after creating it.

Comment 1 Simon Kobyda 2019-09-24 07:51:55 UTC

Resolved:

commit 6b92175157e06d00739916d417cf2311e54a92d5
Author: Simon Kobyda <skobyda>
Date:   Wed Sep 4 16:25:57 2019 +0200

    machines: Implement adding virtual network interfaces
    
    Closes #12711
    https://bugzilla.redhat.com/show_bug.cgi?id=1672753

Comment 3 Xianghua Chen 2019-12-09 08:21:55 UTC

Verified with packages:
cockpit-machines-208-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Prepare a running VM and switch to the network tab of the VM  
2. Click 'Add Network Interface' 
3. Set the parameters below:     
Interface Type: Virtual network         
source: default     
model: virtio     
Mac Adddress: Generate automatically     
Then click the "Add" button
4. Shut down the VM,the network interface should be removed.
5. Reopen the VM, click the 'Add Network Interface', then set the parameters below:     
Interface Type: Virtual network         
source: default     
model: virtio     
Mac Adddress: Generate automatically     
Persistence: Always attach     
Then click the "Add" button
6. Shut down the VM,the network interface should not be removed.

So verified.

Comment 7 errata-xmlrpc 2020-04-28 15:42:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639