Bug 1672861
| Summary: | Review Request: gap-pkg-primgrp - Primitive permutation groups library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Jared Smith <jsmith.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsmith.fedora, mufti11, package-review |
| Target Milestone: | --- | Flags: | jsmith.fedora:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-19 16:21:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jerry James
2019-02-06 04:12:34 UTC
The package fails to build on my machine (fedora 30 x86_64):
$ rpmbuild -ba gap-pkg-primgrp.spec
...
Libs used: gmp, readline
Loading the library and packages ...
#I autpgrp package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I alnuth package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I crisp package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I ctbllib package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I factint package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I fga package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I irredsol package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I laguna package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I polenta package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I polycyclic package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I resclasses package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I sophus package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
#I tomlib package is not available. Check that the name is correct
#I and it is present in one of the GAP root directories (see '??RootPaths')
Components: trans 1.0, prim 2.1, small* 1.0, id* 1.0
Packages: GAPDoc 1.6.2
Try '??help' for help. See also '?copyright', '?cite' and '?authors'
gap> #I PrimGrp package is not available. To see further details, enter
#I SetInfoLevel(InfoPackageLoading,4); and try to load the package again.
fail
gap> > > > Error, <filename> must be a string (not a list (plain,hom)) in
return IsDirectoryPathString( dirname ); at /usr/lib/gap/lib/files.gd:323 called from
IsDirectoryPath( f ) at /usr/lib/gap/lib/test.gi:663 called from
<function "TestDirectory">( <arguments> )
called from read-eval loop at line 5 of *stdin*
you can replace <filename> via 'return <filename>;'
brk> FORCE_QUIT_GAP(1);
error: Bad exit status from /var/tmp/rpm-tmp.BXzsSC (%check)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.BXzsSC (%check)
[mufti@localhost ~]$
You're building with Rawhide's gap package, not the one in the COPR I gave in the initial comment. That's not going to work. For this package, you must have the gap and GAPDoc packages from the COPR repository in your buildroot. $ rpmlint rpmbuild/RPMS/noarch/gap-pkg-primgrp-3.3.2-1.fc30.noarch.rpm ... gap-pkg-primgrp.noarch: W: only-non-binary-in-usr-lib I have to admit, i don't understand this warning 8-( A bug in rpmlint ? No, it's not a bug. It is warning that there are no ELF binaries in /usr/lib, implying that maybe the content should go into /usr/share. In this case, the warning is wrong, but rpmlint has no way to know that. All of the GAP packages, whether arch-specific or noarch, go in /usr/lib/gap. I have thought a few times about trying to come up with some kind of split tree, with the noarch parts in %{_datadir}/gap and the arch-specific parts in %{_libdir}/gap, but I've never had time to see if that would be feasible.
I suspect it is not feasible, since GAP itself assumes everything is in a single tree, but I've never tried either.
fedora-review is failing, but I have manually reviewed this package, and it is APPROVED. The package follows the Fedora Packaging Guidelines, and is under an approved license. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-primgrp Built in Rawhide. |