Bug 1672863

Summary:	Review Request: gap-pkg-transgrp - Transitive groups library
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Jared Smith <jsmith.fedora>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jsmith.fedora, mufti11, package-review
Target Milestone:	---	Flags:	jsmith.fedora: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-19 16:22:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2019-02-06 04:12:46 UTC

Spec URL: https://jjames.fedorapeople.org/gap-pkg-transgrp/gap-pkg-transgrp.spec
SRPM URL: https://jjames.fedorapeople.org/gap-pkg-transgrp/gap-pkg-transgrp-2.0.4-1.fc30.src.rpm
Fedora Account System Username: jjames
Description: A library of transitive groups.  This package contains the code for accessing the library.  The actual data is in the data and data32 subpackages.

See this recent thread on fedora-legal-list about the license:
https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/ODAUBCOSDSVT6USYAZ5XQ4E3MWHVWVIZ/

The introduction of this package is part of an effort to upgrade the gap package to version 4.10.0 in Rawhide.  The gap package has not yet been upgraded, because doing so before the introduction of this package will break sagemath.  Therefore, in order to build this package for review, you will need the packages in this repository: https://copr.fedorainfracloud.org/coprs/jjames/GAP/.

Comment 1 J. Scheurich 2019-02-07 12:21:06 UTC

The package fails build on my machine (fedora 30 x86_64)

$ rpmbuild -ba gap-pkg-transgrp.spec
...
#I  autpgrp package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  alnuth package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  crisp package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  ctbllib package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  factint package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  fga package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  irredsol package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  laguna package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  polenta package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  polycyclic package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  resclasses package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  sophus package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
#I  tomlib package is not available. Check that the name is correct
#I  and it is present in one of the GAP root directories (see '??RootPaths')
 Components: trans 1.0, prim 2.1, small* 1.0, id* 1.0
 Packages:   GAPDoc 1.6.2
 Try '??help' for help. See also '?copyright', '?cite' and '?authors'
gap> gap> gap> gap> gap> gap> gap> #I  TransGrp package is not available. To see further details, enter
#I  SetInfoLevel(InfoPackageLoading,4); and try to load the package again.
fail
gap> gap> > Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `+' on 2 arguments called from
start + 1 at /usr/lib/gap/lib/test.gi:577 called from
func( C[i] ) at /usr/lib/gap/lib/coll.gi:746 called from
List( files, getStones ) at /usr/lib/gap/lib/test.gi:674 called from
<function "TestDirectory">( <arguments> )
 called from read-eval loop at line 10 of *stdin*
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk> 
brk> FORCE_QUIT_GAP(1); # if we ever get here, there was an error
error: Bad exit status from /var/tmp/rpm-tmp.IIMu4x (%check)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.IIMu4x (%check)

Comment 2 Jerry James 2019-02-08 03:50:08 UTC

Same issue as with primgrp.  You have to build with the gap and GAPDoc packages from the COPR repository.

Comment 3 J. Scheurich 2019-02-08 10:46:26 UTC

rpmlint rpmbuild/RPMS/noarch/gap-pkg-transgrp-doc-2.0.4-1.fc30.noarch.rpm
...
gap-pkg-transgrp-doc.noarch: W: hidden-file-or-dir /usr/lib/gap/pkg/transgrp/doc/._manual.pdf

Comment 4 Jerry James 2019-02-13 04:24:31 UTC

Good catch.  I will fix that tomorrow.

Comment 5 Jerry James 2019-02-14 03:45:30 UTC

New URLs:

Spec URL: https://jjames.fedorapeople.org/gap-pkg-transgrp/gap-pkg-transgrp.spec
SRPM URL: https://jjames.fedorapeople.org/gap-pkg-transgrp/gap-pkg-transgrp-2.0.4-2.fc30.src.rpm

Comment 6 Jared Smith 2019-02-15 17:28:06 UTC

I have manually reviewed this package, and it is APPROVED.  It conforms to the Fedora Packaging Guidelines, and is under an acceptible license.  It builds cleanly in Rawhide.

Comment 7 Igor Raits 2019-02-16 10:59:13 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-transgrp

Comment 8 Jerry James 2019-02-19 16:22:34 UTC

Built in Rawhide.