Bug 1672950

Summary: Review Request: perl-Plack-Test-Agent - Object-oriented interface for testing PSGI applications
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Plack-Test-Agent-1.4-1.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-07 15:13:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-02-06 10:07:04 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Plack-Test-Agent/perl-Plack-Test-Agent.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Plack-Test-Agent/perl-Plack-Test-Agent-1.4-1.fc30.src.rpm
Description:
Plack::Test::Agent is an object-oriented interface to test PSGI applications.
It can perform GET and POST requests against PSGI applications either in
process or over HTTP through a Plack::Handler compatible backend.

Fedora Account System Username: ppisar
Comment 1 Jitka Plesnikova 2019-02-06 16:28:48 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Plack-Test-Agent-1.4-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(HTTP::Message::PSGI)
      1 perl(HTTP::Request::Common)
      1 perl(HTTP::Response)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(parent)
      1 perl(Plack::Loader)
      1 perl(Plack::Util::Accessor)
      1 perl(strict)
      1 perl(Test::TCP)
      1 perl(Test::WWW::Mechanize)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Plack-Test-Agent-1.4-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Plack::Test::Agent) = 1.4
      1 perl-Plack-Test-Agent = 1.4-1.fc30 
Binary provides are Ok.

$ rpmlint ./perl-Plack-Test-Agent*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved
Comment 2 Gwyn Ciesla 2019-02-07 14:31:11 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Plack-Test-Agent
Comment 3 Petr Pisar 2019-02-07 15:13:58 UTC 
Thank you for the review and the repository.