Bug 1673321

Summary:	[RFE] Allow to match network devices by PCI Address
Product:	Red Hat Enterprise Linux 8	Reporter:	Till Maas <till>
Component:	NetworkManager	Assignee:	Beniamino Galvani <bgalvani>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	8.0	CC:	atragler, bgalvani, fgiudici, jmaxwell, lrintel, pasik, rkhan, sukulkar, thaller, vbenes
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-1.26.0-0.1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1723391 (view as bug list)		Environment:
Last Closed:	2020-11-04 01:48:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1695634, 1723391, 1807630

Description Till Maas 2019-02-07 11:29:40 UTC

Description of problem:
Currently, NetworkManager only allows to specify devices by name or MAC address. Since the device name is not stable and the MAC address requires an inventory about which MAC addresses are used, it would be nice to be able to specify a network card by PCI address, i.e. 0000:00:1f.6.

Additional info:
This could be implemented by a match setting that already exists for interface-name but not yet for PCI ID.

Comment 1 Thomas Haller 2019-02-07 11:38:10 UTC

do you know how to obtain the PCI address?

Comment 2 Thomas Haller 2019-02-07 11:56:43 UTC

there is:

 - grep PCI_SLOT_NAME /sys/class/net/*/device/uevent

 - ethtool -i eth0
 
     - which uses ETHTOOL_GDRVINFO and "struct ethtool_drvinfo"

 - udevadm info -a -p /sys/class/net/eth0

 - sudo lshw -c network -businfo  

 - lspci -D 

 - udevadm info /sys/class/net/eth0 



Note in `man systemd.link` there is:

       Path=
           A whitespace-separated list of shell-style globs matching the persistent path, as exposed by the udev property "ID_PATH".


and 

  $ udevadm info /sys/class/net/eth0 | grep ID_PATH=



So, we probably want to implement this udev "path".

Comment 9 Beniamino Galvani 2020-06-10 15:37:53 UTC

Upstream merge request:

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/536

Comment 13 Vladimir Benes 2020-06-19 14:01:38 UTC

test case added:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/merge_requests/581

Comment 16 errata-xmlrpc 2020-11-04 01:48:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (NetworkManager bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4499