Bug 167374

Summary: xscreensaver-demo generates bad option for squiral
Product: [Fedora] Fedora Reporter: Bob Schmertz <rschmertz>
Component: xscreensaverAssignee: Ray Strode [halfline] <rstrode>
Status: CLOSED RAWHIDE QA Contact:
Severity: low Docs Contact:
Priority: medium    
Version: 4CC: jwz
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-06 14:38:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Patch to change -density option none

Description Bob Schmertz 2005-09-01 22:53:31 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050720 Fedora/1.0.6-1.1.fc4 Firefox/1.0.6

Description of problem:
The graphical config tool, when configuring the "squiral" screensaver, presents a slider widget for choosing "Density".  Moving this slider causes the tool to create a "-density" command-line option for squiral, but no such option is recognized by squiral.  Squiral won't run again until you remove that command-line option using the Advanced mode.

Version-Release number of selected component (if applicable):
xscreensaver-extras-4.21-4

How reproducible:
Always

Steps to Reproduce:
1. Start xscreensaver-demo (Desktop->Preferences->Screensaver)
2. Select Squiral from the list of screensavers
3. Click Settings under the preview window
4. Find the slider labeled "Density" (Sparse <--> Dense)
5. Move it one way or the other
6. Click OK.
  

Actual Results:  Naive version: Preview window showed "No preview available", and clicking Preview showed a black screen.

Enlightened version: a "-density" option was added to the command line by the GUI tool.

Expected Results:  Naive version: Preview should show squiral in operation, with the squiralies packed all dense and stuff.

Enlightened version: The GUI shouldn't generate a -density option, though I'm at a loss as to what "Density" is supposed to mean w.r.t. the actual available options.  It would also be nice if squiral would just ignore invalid options and drive on.

Additional info:

There is a general lack of correlation between the parameters on the GUI and the command-line params for squiral.  I can't tell which things map to which without futzing with the GUI and then checking the command-line to see what it generates.
Comment 1 Mamoru TASAKA 2005-09-05 17:36:20 UTC 
Created attachment 118477 [details]
Patch to change -density option 

I can easily reproduce this.
From manual file and source file, squiral does not seem
to support -density option, which should be -fill option
( -fill option is supported but not appers on demo ).

I attached a patch against squiral.xml ( which is to be
installed in /usr/share/xscreensaver/config/ ) to fix 
 -density option.
Comment 2 Ray Strode [halfline] 2005-09-06 14:38:30 UTC 
Thanks, applied.

Should be fixed in tomorrow's Rawhide.
Comment 3 Ray Strode [halfline] 2005-09-06 18:45:16 UTC 
*** Bug 167373 has been marked as a duplicate of this bug. ***