Bug 1673833
| Summary: | Build fails due to wrong handling of -Wformat flag | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petra Alice Mikova <pmikova> |
| Component: | java-openjdk | Assignee: | jiri vanek <jvanek> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jerboaa, jvanek, pmikova, sgehwolf |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-14 09:28:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petra Alice Mikova
2019-02-08 09:19:05 UTC
Is this failure happening in rawhide only? So far I don't seem to be able to reproduce on F29. (In reply to Severin Gehwolf from comment #1) > Is this failure happening in rawhide only? So far I don't seem to be able to > reproduce on F29. OK, reproduced on F29. Somewhat expected it fails for the "test-image" target when configured with extra cflags like so: $ bash configure [...] --with-extra-cflags="-Wformat -Werror=format-security" --with-extra-cxxflags="-Wformat -Werror=format-security" [...] $ make [...] test-image It makes we wonder why we build these targets: 'bootcycle-images all docs'. I'd think 'bootcycle-images docs' would be sufficient? Do we actually package anything test image related? Doc for "all" target says: make all # Create all images: product, test, docs # (alias for all-images) Nope. nothig test related is packed Here is an alternative (possible) solution to this problem. Don't build the test image: https://src.fedoraproject.org/fork/jerboaa/rpms/java-openjdk/c/4b97f4ea5da579cd0c9d53f9fe7b4dbffc19a00a?branch=pr23-alt-fix Currently building here: https://koji.fedoraproject.org/koji/taskinfo?taskID=32742439 We'll see how that goes :) It is hiding the issue :) (In reply to jiri vanek from comment #5) > It is hiding the issue :) Sure. I agree. Though, it's unclear whether it's common for somebody to compile test libs with '-Wformat -Werror=format-security'. JDK libs, yes. Test libs, not sure. It might be that it'll get dismissed upstream. What I'm questioning here is whether it makes sense to compile the test image during the build as it's not being packaged anyway. That increases compile time for no good reason (test libs are then thrown away post-build). (In reply to Severin Gehwolf from comment #4) > Currently building here: > https://koji.fedoraproject.org/koji/taskinfo?taskID=32742439 That failed on i686 with an unrelated failure. Trying again here: https://koji.fedoraproject.org/koji/taskinfo?taskID=32759135 FWIW, I'd go with the work-around for the following reasons: a) It reduces build time a bit (no longer compiles test libs needlessly) b) Bug filed upstream as https://bugs.openjdk.java.net/browse/JDK-8218814 So issue has been reported. I'll close this bug as it has been worked around by not compiling the test image during build. See: https://koji.fedoraproject.org/koji/buildinfo?buildID=1209090 Feel free to re-open if you feel otherwise. |