Bug 1674522

Summary:	Review Request: perl-LWP-ConsoleLogger - LWP tracing and debugging
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-LWP-ConsoleLogger-0.000039-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-12 17:32:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-02-11 14:42:29 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-LWP-ConsoleLogger/perl-LWP-ConsoleLogger.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-LWP-ConsoleLogger/perl-LWP-ConsoleLogger-0.000039-1.fc30.src.rpm
Description:
It can be hard (or at least tedious) to debug WWW::Mechanize scripts.
LWP::ConsoleLogger::Easy wrapper offers debug_ua() function that instantiates
LWP logging and also returns a LWP::ConsoleLogger object, which you may then
tweak to your heart's desire. If you need to tweak the settings that
LWP::ConsoleLogger::Easy chooses for you, please use LWP::ConsoleLogger. If
you're able to install HTML::FormatText::Lynx then you'll get highly readable
HTML to text conversions.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-02-12 12:20:29 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: perl(Test::Needs) is required only for network test. It is required
      only with enable "perl_LWP_ConsoleLogger_enables_network_test"

$ rpm -qp --requires perl-LWP-ConsoleLogger-0.000039-1.fc30.noarch.rpm | grep -v rpmlib | sort | uniq -c
      1 perl(Class::Method::Modifiers)
      1 perl(Data::Printer) >= 0.36
      1 perl(DateTime)
      1 perl(HTML::Restrict)
      1 perl(HTTP::Body)
      1 perl(HTTP::CookieMonster)
      1 perl(JSON::MaybeXS) >= 1.003005
      1 perl(List::AllUtils)
      1 perl(Log::Dispatch) >= 2.56
      1 perl(LWP::ConsoleLogger)
      1 perl(LWP::ConsoleLogger::Easy)
      1 perl(LWP::UserAgent)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Module::Load::Conditional)
      1 perl(Moo)
      1 perl(MooX::StrictConstructor)
      1 perl(Parse::MIME)
      1 perl(Ref::Util)
      1 perl(strict)
      1 perl(String::Trim)
      1 perl(Sub::Exporter)
      1 perl(Term::Size::Any)
      1 perl(Text::SimpleTable::AutoWidth) >= 0.09
      1 perl(Try::Tiny)
      1 perl(Types::Common::Numeric)
      1 perl(Types::Standard)
      1 perl(URI::Query)
      1 perl(URI::QueryParam)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings)
      1 perl(XML::Simple)
Binary requires are Ok.

$ rpm -qp --provides perl-LWP-ConsoleLogger-0.000039-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(LWP::ConsoleLogger) = 0.000039
      1 perl-LWP-ConsoleLogger = 0.000039-1.fc30
      1 perl(LWP::ConsoleLogger::Easy) = 0.000039
      1 perl(LWP::ConsoleLogger::Everywhere) = 0.000039
Binary provides are Ok.

$ rpmlint ./perl-LWP-ConsoleLogger*
perl-LWP-ConsoleLogger.noarch: W: spelling-error %description -l en_US ua -> ya, us, u
perl-LWP-ConsoleLogger.src: W: spelling-error %description -l en_US ua -> ya, us, u
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

Please consider fixing 'TODO' item.

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-02-12 15:07:10 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-LWP-ConsoleLogger

Comment 3 Petr Pisar 2019-02-12 17:32:42 UTC

Thank you for the review and the repository. I made the Test::Needs dependency needed only for network tests.