Bug 1674655

Created attachment 1529279 [details]
build.log

file build.log too big, will only attach last 1024 bytes

Created attachment 1529280 [details]
root.log

file root.log too big, will only attach last 1024 bytes

Created attachment 1529281 [details]
state.log

BUILDSTDERR: /usr/bin/ld: CMakeFiles/eqsl.dir/eqsl.cpp.o: undefined reference to symbol 'pthread_condattr_setclock@@GLIBC_2.3.3'
BUILDSTDERR: /usr/bin/ld: //usr/lib64/libpthread.so.0: error adding symbols: DSO missing from command line
BUILDSTDERR: collect2: error: ld returned 1 exit status

It looks like "aqsis-core" is not installable in fedora 30 (x86_64)

# dnf install aqsis-core
Last metadata expiration check: 0:03:47 ago on Sat 09 Mar 2019 04:19:02
PM CET.
Error:
  Problem: conflicting requests
   - nothing provides libboost_system.so.1.66.0()(64bit) needed by
aqsis-core-1.8.2-31.fc29.x86_64
   - nothing provides libboost_thread.so.1.66.0()(64bit) needed by
aqsis-core-1.8.2-31.fc29.x86_64
   - nothing provides libboost_filesystem.so.1.66.0()(64bit) needed by
aqsis-core-1.8.2-31.fc29.x86_64
   - nothing provides libboost_regex.so.1.66.0()(64bit) needed by
aqsis-core-1.8.2-31.fc29.x86_64
   - nothing provides libboost_iostreams.so.1.66.0()(64bit) needed by
aqsis-core-1.8.2-31.fc29.x86_64
   - nothing provides libboost_wave.so.1.66.0()(64bit) needed by
aqsis-core-1.8.2-31.fc29.x86_64
(try to add '--skip-broken' to skip uninstallable packages)

I need aqsis-core (a renderer for .RIB files) as requirement for white_dune.

A brute force work-around to the FTBFS would be to append "-pthread" to CXXFLAGS, e.g. to apply the change below to the *.spec:

--- aqsis.spec~ 2019-03-31 07:33:12.000000000 +0200
+++ aqsis.spec  2019-03-31 07:52:26.905247350 +0200
@@ -128,7 +128,7 @@
   -DAQSIS_BOOST_REGEX_LIBRARY_NAME=boost_regex-mt \
   -DAQSIS_BOOST_THREAD_LIBRARY_NAME=boost_thread-mt \
   -DAQSIS_BOOST_WAVE_LIBRARY_NAME=boost_wave-mt \
-  -DCMAKE_CXX_FLAGS="$CXXFLAGS -DBOOST_FILESYSTEM_VERSION=3" \
+  -DCMAKE_CXX_FLAGS="$CXXFLAGS -DBOOST_FILESYSTEM_VERSION=3 -pthread" \
   -DAQSIS_USE_EXTERNAL_TINYXML:BOOL=OFF ..
 
 make VERBOSE=1 %{?_smp_mflags}

Created attachment 1552303 [details]
Proposed patch

Unless somebody objects, I intent to apply this patch to f30 and rawhide later today or tomorrow.

Thx for looking into this.

A a side note, bundling with sytem tinyxml was not that trivial, given aqsis actually bundled a 2.5.x modified copy to fixes known issues (that can be experienced at runtime).

Do you have a working scratch build ?
If it's the case, please go ahead and apply the fix (I would prefer without the tinxyxml unbundling).

(In reply to Nicolas Chauvet (kwizart) from comment #8)
> Thx for looking into this.
> 
> A a side note, bundling with sytem tinyxml was not that trivial, given aqsis
> actually bundled a 2.5.x modified copy to fixes known issues (that can be
> experienced at runtime).
> 
> Do you have a working scratch build ?
Yes, cf. https://koji.fedoraproject.org/koji/taskinfo?taskID=33964140

> If it's the case, please go ahead and apply the fix (I would prefer without
> the tinxyxml unbundling).
I can revert this part, if you prefer.

(In reply to Ralf Corsepius from comment #9)
...
> > the tinxyxml unbundling).
> I can revert this part, if you prefer.
Yes, please discard the tinyxml unbundling.

(In reply to Nicolas Chauvet (kwizart) from comment #10)
> (In reply to Ralf Corsepius from comment #9)
> ...
> > > the tinxyxml unbundling).
> > I can revert this part, if you prefer.
> Yes, please discard the tinyxml unbundling.
Can you explain why? I haven't checked details, but to me, bundling a version which is dead and unmaintained for at least 7 years doesn't appear to be necessarily wise.

Well, I've already explained, the tinyxml bundled is modifed and using a system version will break at runtime.
The only way forward is to migrate to tinyxml2.

(In reply to Nicolas Chauvet (kwizart) from comment #12)
> Well, I've already explained, the tinyxml bundled is modifed
It is not. The code is identical to tinyxml-2.5.2.

aqsis-1.8.2-33.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-09137db22f

Indeed. My bad.
Let's move to system tinyxml since there is no reason left to bundle.

aqsis-1.8.2-33.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-09137db22f

aqsis-1.8.2-33.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.