Bug 1674884

Summary: firefox: FTBFS in Fedora rawhide/f31
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: firefoxAssignee: Martin Stransky <stransky>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: 0xalen, anto.trande, gecko-bugs-nobody, jgrulich, jhorak, john.j5live, jpokorny, kengert, pjasicek, rhughes, rstrode, sandmann, stransky
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-25 15:20:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 1674516    
Description Flags
state.log none

Description Fedora Release Engineering 2019-02-11 17:11:48 UTC
firefox failed to build from source in Fedora rawhide/f30


For details on the mass rebuild see:

Please fix firefox at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
firefox will be orphaned. Before branching of Fedora 31,
firefox will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:

Comment 1 Fedora Release Engineering 2019-02-11 17:11:53 UTC
Created attachment 1529930 [details]

file build.log too big, will only attach last 1024 bytes

Comment 2 Fedora Release Engineering 2019-02-11 17:11:55 UTC
Created attachment 1529931 [details]

file root.log too big, will only attach last 1024 bytes

Comment 3 Fedora Release Engineering 2019-02-11 17:11:56 UTC
Created attachment 1529932 [details]

Comment 4 Jan Pokorný [poki] 2019-03-21 08:29:32 UTC
Was wondering why Rawhide is effectively 2 major releases behind.

The problem seems to be:

> 4:20.54 In file included from /builddir/build/BUILD/firefox-66.0/objdir/js/src/Unified_cpp_js_src10.cpp:2:
> 4:20.54 /builddir/build/BUILD/firefox-66.0/js/src/util/NativeStack.cpp:28:14: error: 'pid_t gettid()' was declared 'extern' and later 'static' [-fpermissive]
> 4:20.54    28 | static pid_t gettid() { return syscall(__NR_gettid); }
> 4:20.54       |              ^~~~~~
> 4:20.54 In file included from /usr/include/unistd.h:1170,
> 4:20.54                  from /builddir/build/BUILD/firefox-66.0/objdir/dist/system_wrappers/unistd.h:3,
> 4:20.54                  from /builddir/build/BUILD/firefox-66.0/js/src/util/NativeStack.cpp:27,
> 4:20.54                  from /builddir/build/BUILD/firefox-66.0/objdir/js/src/Unified_cpp_js_src10.cpp:2:
> 4:20.54 /usr/include/bits/unistd_ext.h:34:16: note: previous declaration of '__pid_t gettid()'
> 4:20.54    34 | extern __pid_t gettid (void) __THROW;
> 4:20.54       |                ^~~~~~

per https://kojipkgs.fedoraproject.org//work/tasks/2420/33652420/build.log
from buildArch (firefox-66.0-7.test.fc31.src.rpm, x86_64) task.

Also looks like at least v65 is available as an update for the stable
Fedora, which violates the principle of monotonicity, which is perhaps
just not enforced anymore.

Comment 5 Antonio 2019-03-21 19:02:43 UTC
This patch looks fix the error on f31 (it worked for IceCat): https://hg.mozilla.org/mozilla-central/rev/7b85bf9c5210
Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1533969

Comment 6 Martin Stransky 2019-03-21 21:29:29 UTC
Great, thanks a lot.

Comment 7 Martin Stransky 2019-03-25 15:20:27 UTC
Fixed with the provided patch, Thanks.

Comment 8 Jan Pokorný [poki] 2019-03-25 15:48:28 UTC