Bug 1674980

Summary: glom: FTBFS in Fedora rawhide/f30
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: glomAssignee: Haïkel Guémar <karlthered>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jwakely, karlthered
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-12 00:09:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1674516    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2019-02-11 18:27:11 UTC
glom failed to build from source in Fedora rawhide/f30

https://koji.fedoraproject.org/koji/taskinfo?taskID=32392708


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Please fix glom at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
glom will be orphaned. Before branching of Fedora 31,
glom will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2019-02-11 18:27:14 UTC
Created attachment 1530164 [details]
build.log

file build.log too big, will only attach last 1024 bytes

Comment 2 Fedora Release Engineering 2019-02-11 18:27:15 UTC
Created attachment 1530165 [details]
root.log

file root.log too big, will only attach last 1024 bytes

Comment 3 Fedora Release Engineering 2019-02-11 18:27:16 UTC
Created attachment 1530166 [details]
state.log

Comment 4 Jonathan Wakely 2019-02-11 21:26:54 UTC
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... no
checking whether g++ supports C++11 features with -std=c++0x... no
checking whether g++ supports C++11 features with +std=c++11... no
BUILDSTDERR: configure: error: *** A compiler with support for C++11 language features is required.

The checks are clearly broken.

Comment 5 Jonathan Wakely 2019-02-11 22:46:44 UTC
The package is missing BuildRequires: gcc-c++

I'm trying a new build now.

Comment 6 Jonathan Wakely 2019-02-12 00:09:42 UTC
/usr/include/c++/9/ext/new_allocator.h: In instantiation of 'void __gnu_cxx::new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = Glom::AddDelColumnInfo; _Args = {Glom::AddDelColumnInfo}; _Tp = Glom::AddDelColumnInfo]':
/usr/include/c++/9/bits/alloc_traits.h:482:2:   required from 'static void std::allocator_traits<std::allocator<_CharT> >::construct(std::allocator_traits<std::allocator<_CharT> >::allocator_type&, _Up*, _Args&& ...) [with _Up = Glom::AddDelColumnInfo; _Args = {Glom::AddDelColumnInfo}; _Tp = Glom::AddDelColumnInfo; std::allocator_traits<std::allocator<_CharT> >::allocator_type = std::allocator<Glom::AddDelColumnInfo>]'
/usr/include/c++/9/bits/stl_uninitialized.h:888:67:   required from 'void std::__relocate_object_a(_Tp*, _Up*, _Allocator&) [with _Tp = Glom::AddDelColumnInfo; _Up = Glom::AddDelColumnInfo; _Allocator = std::allocator<Glom::AddDelColumnInfo>]'
/usr/include/c++/9/bits/stl_uninitialized.h:919:47:   required from '_ForwardIterator std::__relocate_a_1(_InputIterator, _InputIterator, _ForwardIterator, _Allocator&) [with _InputIterator = Glom::AddDelColumnInfo*; _ForwardIterator = Glom::AddDelColumnInfo*; _Allocator = std::allocator<Glom::AddDelColumnInfo>]'
/usr/include/c++/9/bits/stl_uninitialized.h:940:37:   required from '_ForwardIterator std::__relocate_a(_InputIterator, _InputIterator, _ForwardIterator, _Allocator&) [with _InputIterator = Glom::AddDelColumnInfo*; _ForwardIterator = Glom::AddDelColumnInfo*; _Allocator = std::allocator<Glom::AddDelColumnInfo>]'
/usr/include/c++/9/bits/stl_vector.h:430:35:   required from 'static constexpr bool std::vector<_Tp, _Alloc>::_S_use_relocate() [with _Tp = Glom::AddDelColumnInfo; _Alloc = std::allocator<Glom::AddDelColumnInfo>]'
/usr/include/c++/9/bits/vector.tcc:460:33:   required from 'void std::vector<_Tp, _Alloc>::_M_realloc_insert(std::vector<_Tp, _Alloc>::iterator, _Args&& ...) [with _Args = {const Glom::AddDelColumnInfo&}; _Tp = Glom::AddDelColumnInfo; _Alloc = std::allocator<Glom::AddDelColumnInfo>; std::vector<_Tp, _Alloc>::iterator = __gnu_cxx::__normal_iterator<Glom::AddDelColumnInfo*, std::vector<Glom::AddDelColumnInfo> >; typename std::_Vector_base<_Tp, _Alloc>::pointer = Glom::AddDelColumnInfo*]'
/usr/include/c++/9/bits/stl_vector.h:1162:4:   required from 'void std::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = Glom::AddDelColumnInfo; _Alloc = std::allocator<Glom::AddDelColumnInfo>; std::vector<_Tp, _Alloc>::value_type = Glom::AddDelColumnInfo]'
glom/utility_widgets/adddel/adddel.cc:863:38:   required from here
/usr/include/c++/9/ext/new_allocator.h:145:20: error: use of deleted function 'Glom::AddDelColumnInfo::AddDelColumnInfo(Glom::AddDelColumnInfo&&)'
  145 |  noexcept(noexcept(::new((void *)__p)
      |                    ^~~~~~~~~~~~~~~~~~
  146 |        _Up(std::forward<_Args>(__args)...)))
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from glom/utility_widgets/adddel/adddel.cc:23:
./glom/utility_widgets/adddel/adddel.h:44:3: note: declared here
   44 |   AddDelColumnInfo(AddDelColumnInfo&& src) = delete;
      |   ^~~~~~~~~~~~~~~~


Explicitly deleting a move constructor is almost never the right thing to do (and it was already changed upstream long ago). It fails because of a GCC change, but I've already patched GCC to accept the code (even though it's actually invalid C++): https://gcc.gnu.org/PR89130

Once a new GCC lands in rawhide this package would build again, but I've patched it anyway, and it's built:         http://koji.fedoraproject.org/koji/buildinfo?buildID=1187790