Bug 1675047

Summary: golang-honnef-tools: FTBFS in Fedora rawhide/f30
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: golang-honnef-toolsAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: go-sig, jcajka, jchaloup, nicolas.mailhot, zebob.m
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: golang-honnef-tools-2019.1-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-20 15:40:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1674516    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2019-02-11 18:37:23 UTC
golang-honnef-tools failed to build from source in Fedora rawhide/f30

https://koji.fedoraproject.org/koji/taskinfo?taskID=32397560


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Please fix golang-honnef-tools at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
golang-honnef-tools will be orphaned. Before branching of Fedora 31,
golang-honnef-tools will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source

Comment 1 Fedora Release Engineering 2019-02-11 18:37:26 UTC
Created attachment 1530353 [details]
build.log

file build.log too big, will only attach last 1024 bytes

Comment 2 Fedora Release Engineering 2019-02-11 18:37:27 UTC
Created attachment 1530354 [details]
root.log

file root.log too big, will only attach last 1024 bytes

Comment 3 Fedora Release Engineering 2019-02-11 18:37:29 UTC
Created attachment 1530355 [details]
state.log

Comment 4 Jakub Čajka 2019-02-13 19:53:30 UTC
Caused by the tests not passing lint:
+ go test -buildmode pie -compiler gc -ldflags '-extldflags '\''-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '\'''
--- FAIL: TestAll (8.01s)
    util.go:118: Lint failed at CheckDeprecated_go14.go:18; /ErrWriteAfterFlush is no longer used/ did not match
    util.go:126: Unexpected problem at testdata/CheckDeprecated_go14.go:18:12: http.ErrWriteAfterFlush is deprecated: ErrWriteAfterFlush is no longer returned by anything in the net/http package. Callers should not compare errors against this variable. 
    util.go:118: Lint failed at CheckDeprecated_go18.go:18; /ErrWriteAfterFlush is no longer used/ did not match
    util.go:126: Unexpected problem at testdata/CheckDeprecated_go18.go:18:12: http.ErrWriteAfterFlush is deprecated: ErrWriteAfterFlush is no longer returned by anything in the net/http package. Callers should not compare errors against this variable. 
FAIL
exit status 1
FAIL	honnef.co/go/tools/staticcheck	8.086s

Comment 5 Fedora Update System 2019-02-20 15:39:34 UTC
golang-honnef-tools-2019.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-0e8347f23a

Comment 6 Robert-André Mauchin 🐧 2019-02-20 15:40:14 UTC
Update to 2019.1 solve the issue.

Comment 7 Fedora Update System 2019-02-21 03:47:22 UTC
golang-honnef-tools-2019.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-0e8347f23a

Comment 8 Fedora Update System 2019-03-02 01:46:45 UTC
golang-honnef-tools-2019.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.