Bug 1676023

Summary:	python-pytest-httpbin-1.0.0 is available
Product:	[Fedora] Fedora	Reporter:	Upstream Release Monitoring <upstream-release-monitoring>
Component:	python-pytest-httpbin	Assignee:	Miro Hrončok <mhroncok>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	awilliam, mhroncok
Target Milestone:	---	Keywords:	FutureFeature, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-pytest-httpbin-1.0.0-1.fc33 python-pytest-httpbin-1.0.0-1.eln103	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-11 08:34:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1855876

Description Upstream Release Monitoring 2019-02-11 22:01:21 UTC

Latest upstream release: 1.0.0
Current version/release in rawhide: 0.3.0-7.fc30
URL: https://github.com/kevin1024/pytest-httpbin

Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy

More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring

Please keep in mind that with any upstream change, there may also be packaging changes that need to be made. Specifically, please remember that it is your responsibility to review the new version to ensure that the licensing is still correct and that no non-free or legally problematic items have been added upstream.

Based on the information from anitya:  https://release-monitoring.org/project/12741/

Comment 1 Adam Williamson 2019-02-11 22:57:36 UTC

Upstream release notes indicate the change in 1.0.0 may break the requests test suite, which is the primary reason this is packaged at all, so I'm holding off on this for now:

https://github.com/kevin1024/pytest-httpbin/releases/tag/v1.0.0

"Update included self-signed cert to include IP address in SAN (See #52). Full version bump because this could be a breaking change for those depending on the certificate missing the IP address in the SAN (as it seems the requests test suite does)"

Comment 2 Miro Hrončok 2020-07-10 22:27:19 UTC

We may have a problem now.

With the old certificates, we are hitting bz1855876 when testing requests.

With the new certificates, we don't get the expected SubjectAltNameWarning in requests test:

=================================== FAILURES ===================================
_______________________ TestRequests.test_https_warnings _______________________

self = <tests.test_requests.TestRequests object at 0x7fc802ebaa60>
httpbin_secure = <function prepare_url.<locals>.inner at 0x7fc8031980d0>
httpbin_ca_bundle = None

    def test_https_warnings(self, httpbin_secure, httpbin_ca_bundle):
        """warnings are emitted with requests.get"""
        if HAS_MODERN_SSL or HAS_PYOPENSSL:
            warnings_expected = ('SubjectAltNameWarning', )
        else:
            warnings_expected = ('SNIMissingWarning',
                                 'InsecurePlatformWarning',
                                 'SubjectAltNameWarning', )
    
        with pytest.warns(None) as warning_records:
            warnings.simplefilter('always')
            requests.get(httpbin_secure('status', '200'),
                         verify=httpbin_ca_bundle)
    
        warning_records = [item for item in warning_records
                           if item.category.__name__ != 'ResourceWarning']
    
        warnings_category = tuple(
            item.category.__name__ for item in warning_records)
>       assert warnings_category == warnings_expected
E       AssertionError: assert () == ('SubjectAltNameWarning',)
E         Right contains one more item: 'SubjectAltNameWarning'
E         Full diff:
E         - ()
E         + ('SubjectAltNameWarning',)

tests/test_requests.py:855: AssertionError
----------------------------- Captured stderr call -----------------------------
127.0.0.1 - - [11/Jul/2020 00:24:33] "GET /status/200 HTTP/1.1" 200 0
======== 1 failed, 526 passed, 12 skipped, 1 xfailed in 175.72 seconds =========



I've inspected test_https_warnings and it simply makes assumptions about certificates in pytest-httpbin.

I suggest we do update this, deselect test_https_warnings, and open an upstream requests issue.

Comment 3 Miro Hrončok 2020-07-10 22:38:22 UTC

https://github.com/psf/requests/issues/5530

Comment 4 Miro Hrončok 2020-07-10 22:41:38 UTC

https://src.fedoraproject.org/rpms/python-pytest-httpbin/pull-request/1

Comment 5 Fedora Update System 2020-07-28 01:59:06 UTC

FEDORA-2020-ad9333f5c4 has been pushed to the Fedora ELN stable repository.
If problem still persists, please make note of it in this bug report.