Bug 1676257

Summary: yubihsm-shell: FTBFS in Fedora rawhide/f30
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: yubihsm-shellAssignee: Jakub Jelen <jjelen>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: jjelen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: yubihsm-shell-2.0.0-4.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-13 13:59:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1674516    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2019-02-11 22:27:14 UTC 
yubihsm-shell failed to build from source in Fedora rawhide/f30

https://koji.fedoraproject.org/koji/taskinfo?taskID=32512979


For details on the mass rebuild see:

https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Please fix yubihsm-shell at your earliest convenience and set the bug's status to
ASSIGNED when you start fixing it. If the bug remains in NEW state for 8 weeks,
yubihsm-shell will be orphaned. Before branching of Fedora 31,
yubihsm-shell will be retired, if it still fails to build.

For more details on the FTBFS policy, please visit:
https://fedoraproject.org/wiki/Fails_to_build_from_source
Comment 1 Fedora Release Engineering 2019-02-11 22:27:16 UTC 
Created attachment 1533709 [details]
build.log

file build.log too big, will only attach last 1024 bytes
Comment 2 Fedora Release Engineering 2019-02-11 22:27:17 UTC 
Created attachment 1533710 [details]
root.log

file root.log too big, will only attach last 1024 bytes
Comment 3 Fedora Release Engineering 2019-02-11 22:27:19 UTC 
Created attachment 1533711 [details]
state.log
Comment 4 Jakub Jelen 2019-02-12 10:40:07 UTC 
The error is the following:

/builddir/build/BUILD/yubihsm-shell-2.0.0/pkcs11/tests/ecdh_derive_test.c: In function 'main':
/builddir/build/BUILD/yubihsm-shell-2.0.0/pkcs11/tests/ecdh_derive_test.c:368:17: error: variable-length array bound is unknown [-Werror=vla-larger-than=]
  368 |   unsigned char ecdh1_bytes[ecdh1_len]; // public key in DER
      |                 ^
/builddir/build/BUILD/yubihsm-shell-2.0.0/pkcs11/tests/ecdh_derive_test.c:419:41: error: variable-length array bound is unknown [-Werror=vla-larger-than=]
  419 |   unsigned char ecdh1_value[ecdh1_len], ecdh2_value[ecdh2_len];
      |                                         ^
lto1: all warnings being treated as errors
lto-wrapper: fatal error: /usr/bin/cc returned 1 exit status

This is caused a new warning (being treated as an error?), but I do not see this as an error at all. It is variable length array so indeed the bound is unknown. But the same construction is used in many other places, where it is not a problem for gcc.
Comment 5 Jakub Jelen 2019-02-13 13:59:46 UTC 
Fixed in rawhide, filled upstream bug.