Bug 1676300

Summary:	Review Request: R-sys - Powerful and Reliable Tools for Running System Commands in R
Product:	[Fedora] Fedora	Reporter:	Elliott Sales de Andrade <quantum.analyst>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jamatos, package-review
Target Milestone:	---	Flags:	jamatos: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-24 02:32:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Elliott Sales de Andrade 2019-02-11 22:32:46 UTC

Spec URL: https://qulogic.fedorapeople.org//R-sys.spec
SRPM URL: https://qulogic.fedorapeople.org//R-sys-2.1-1.fc29.src.rpm

Description:
Drop-in replacements for the base system2() function with fine control and
consistent behavior across platforms. Supports clean interruption, timeout,
background tasks, and streaming STDIN / STDOUT / STDERR over binary or text
connections. Arguments on Windows automatically get encoded and quoted to work
on different locales. On Unix platforms the package also provides functions for
evaluating expressions inside a temporary fork. Such evaluations have no side
effects on the main R process, and support reliable interrupts and timeouts.
This provides the basis for a sandboxing mechanism.

Comment 1 Elliott Sales de Andrade 2019-02-11 22:32:48 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=32746846

Comment 2 José Matos 2019-02-14 09:49:50 UTC

The license is correct and appropriate.

The simple file is simple and readable. :-)

The only complaint that I get from fedora-review is:

- Package does not contain duplicates in %files.
  Note: BUILDSTDERR: warning: File listed twice:
  /usr/lib64/R/library/sys/help
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

That is correct help appears twice in the %file section. The fix is so simple that I am sure you will do it on import.

So the package is approved.

Comment 3 Gwyn Ciesla 2019-02-14 15:02:19 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-sys

Comment 4 Fedora Update System 2019-02-15 03:05:37 UTC

R-sys-2.1-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f3707f1d76

Comment 5 Fedora Update System 2019-02-15 03:05:52 UTC

R-sys-2.1-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9db18f862f

Comment 6 Fedora Update System 2019-02-16 01:17:15 UTC

R-sys-2.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f3707f1d76

Comment 7 Fedora Update System 2019-02-16 03:04:59 UTC

R-sys-2.1-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9db18f862f

Comment 8 Fedora Update System 2019-02-24 02:32:42 UTC

R-sys-2.1-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2019-02-24 04:08:33 UTC

R-sys-2.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.