Bug 1676594

Summary:	[RFE] [machines] Support disk: Physical Disk Device type
Product:	Red Hat Enterprise Linux 8	Reporter:	Javier Coscia <jcoscia>
Component:	cockpit-appstream	Assignee:	Martin Pitt <mpitt>
Status:	CLOSED ERRATA	QA Contact:	YunmingYang <yunyang>
Severity:	low	Docs Contact:
Priority:	medium
Version:	8.0	CC:	kkoukiou, mtessun, qiyuan, xchen, yunyang
Target Milestone:	rc	Keywords:	Rebase
Target Release:	8.1	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-11-05 20:41:39 UTC	Type:	Enhancement
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Javier Coscia 2019-02-12 16:06:59 UTC

Description of problem:

Currently, when creating a new Storagel Pool connection, there is no 
option to select `disk` type, only Filesystem Directory and Network File 
System are offered.

Version-Release number of selected component (if applicable):

kernel-4.18.0-64.el8.x86_64
cockpit-system-184-1.el8.noarch

How reproducible:

100%

Steps to Reproduce:

From cockpit UI:

 Virtual Machines -> Storage Pools -> Create Storage Pool


Actual results:

There is no option offered to select disk storage pool type when creating 
a new one.

Expected results:

Support `disk` storage pool type when creating a new storage pool connection

Additional info:

Comment 1 Katerina Koukiou 2019-05-20 16:00:55 UTC

It's been currently worked in this PR https://github.com/cockpit-project/cockpit/pull/11870

Comment 3 YunmingYang 2019-06-20 03:01:45 UTC

Test Versions:
cockpit-machines-196-1.el8.noarch
libvirt-dbus-1.2.0-2.module+el8.1.0+2983+b2ae9c0a.x86_64


Test Steps:
1.Prepare a disk device(such as /dev/sdb)
2.Format the disk device by 'dd if=/dev/zero of=${device_name} bs=4k count=${num}', then part it by 'parted ${device_name} mktable ${partition}'
3.Create the Physical Disk storage pool through the page, then check it by 'virsh pool-list'


Test Results:
1. The storage pool can be created successfully


According to the results, move the status to VERIFIED.

Comment 5 errata-xmlrpc 2019-11-05 20:41:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3325