Bug 1676600

Summary:	[RFE] [machines] Support LVM: Logical Volume Group type
Product:	Red Hat Enterprise Linux 8	Reporter:	Javier Coscia <jcoscia>
Component:	cockpit-appstream	Assignee:	Martin Pitt <mpitt>
Status:	CLOSED ERRATA	QA Contact:	YunmingYang <yunyang>
Severity:	low	Docs Contact:
Priority:	medium
Version:	8.0	CC:	mpitt, mtessun, qiyuan, xchen
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	8.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 15:42:36 UTC	Type:	Enhancement
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Javier Coscia 2019-02-12 16:12:01 UTC

Description of problem:

Currently, when creating a new Storage Pool connection, there is no 
option to select `LVM` type, only Filesystem Directory and Network File 
System are offered.

Version-Release number of selected component (if applicable):

kernel-4.18.0-64.el8.x86_64
cockpit-system-184-1.el8.noarch

How reproducible:

100%

Steps to Reproduce:

From cockpit UI:

 Virtual Machines -> Storage Pools -> Create Storage Pool


Actual results:

There is no option offered to select `LVM` storage pool type when creating 
a new one.

Expected results:

Support `LVM` storage pool type when creating a new storage pool connection

Additional info:

Comment 1 Martin Pitt 2019-08-06 09:15:53 UTC

This is added upstream in https://github.com/cockpit-project/cockpit/pull/12473 . Tentatively adding for 8.1.0. @Yunming, if this is okay with you, can you please QA ack? Otherwise landing this for 8.2 works for us, too.

Comment 2 YunmingYang 2019-08-07 06:30:55 UTC

@Martin, I think that the version of cockpit-machines should be rebased if this features is added in RHEL-8.1. Should we try to avoid to rebase the version at this time? I have receive an email, which is '8.1 Bug Freeze / Full Freeze is in 2 weeks'. So I suggest we add this feature in 8.2.

Comment 3 Martin Pitt 2019-08-07 06:56:29 UTC

@Yunming: Works for me, moving to 8.2.0. Thanks!

Comment 4 Martin Pitt 2019-08-08 05:29:33 UTC

Released this in upstream version 200.

Comment 6 Xianghua Chen 2019-12-10 06:35:12 UTC

Verified with packages:
cockpit-machines-208-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Prepare volume group resource
2. Login cockpit with root
3. Open Storage Pools page, click "Create Storage Pool" , configure as:
Name: lvm-pool
Type: LVM Volume Group
Source Volume Group:The name of the volume group which is created in step 1
Click "Create"
4. Click "Create Volume" under the new created lvm pool, input storage volume name and click create

The Storage Pool can be created successfully in step 3.
The volume can be created in step 4.

Comment 9 errata-xmlrpc 2020-04-28 15:42:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639