Bug 167675

Summary: patch segfaults when trying to run gdm through beehive
Product: [Fedora] Fedora Reporter: Ray Strode [halfline] <rstrode>
Component: patchAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Brock Organ <borgan>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: drepper.fsp, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.5.4-27 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-07 04:06:49 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Attachments:
Description Flags
Source file that was being patched
none
Patch that was being applied
none
Fix crash, don't read over end of string. none

Comment 1 Ray Strode [halfline] 2005-09-06 17:00:03 EDT
Created attachment 118531 [details]
Source file that was being patched
Comment 2 Ray Strode [halfline] 2005-09-06 17:02:28 EDT
Created attachment 118532 [details]
Patch that was being applied

Note this patch has been applied before without problems, so it's probably a
recent bug in rawhide patch.
Comment 3 Tomas Mraz 2005-09-06 17:16:53 EDT
Patch seems to crash on any input (at least on ppc64 and s390x).

Here is the backtrace if it helps:
Program received signal SIGSEGV, Segmentation fault.
0x0000000010006c1c in partime (s=Variable "s" is not available.
) at partime.c:794
794             while (!ISALNUM ((unsigned char) *s))
(gdb) bt
#0  0x0000000010006c1c in partime (s=Variable "s" is not available.
) at partime.c:794
#1  0x00000000100050e0 in str2time (source=0x1fffffff048,
    default_time=1126041112, default_zone=2199023250672) at maketime.c:475
#2  0x0000000010011898 in fetchname (
    at=0x1002d284 "mx4j/build/build.xml.orig\tThu Dec 23 18:35:27 2004\n",
    strip_leading=1, pstamp=0x1fffffff308) at util.c:1004
#3  0x000000001000e6d4 in there_is_another_patch () at pch.c:389
#4  0x24000442fffffa10 in ?? ()
#5  0x0000000010008688 in main (argc=2, argv=0x1fffffff9f8) at patch.c:178
#6  0x2800044200000000 in ?? ()
#7  0x00000080000cd13c in .generic_start_main () from /lib64/libc.so.6
#8  0x00000080000cd334 in .__libc_start_main () from /lib64/libc.so.6
#9  0x0000000000000000 in ?? ()

I'd suspect some change in compiler caused the segfault.
Comment 4 Ulrich Drepper 2005-09-06 18:41:48 EDT
Created attachment 118536 [details]
Fix crash, don't read over end of string.
Comment 5 Tim Waugh 2005-09-07 04:06:49 EDT
Thanks.  Patch applied in 2.5.4-27.