Bug 1677068

Summary: [RFE] Support ignoring autoconnect when creating new profiles/connections via D-Bus
Product: Red Hat Enterprise Linux 8 Reporter: Till Maas <till>
Component: NetworkManagerAssignee: Thomas Haller <thaller>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.1CC: atragler, bgalvani, edwardh, fgiudici, fpokryvk, lrintel, rkhan, sukulkar, thaller, vbenes, wchadwic
Target Milestone: rcKeywords: FutureFeature
Target Release: 8.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: NetworkManager-1.20.0-4.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-05 22:29:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1689408, 1701002    

Description Till Maas 2019-02-13 22:25:13 UTC
Description of problem:
To update a connection, the D-Bus API allows to ignore autoconnect with the Update2() flag NM_SETTINGS_UPDATE2_FLAG_BLOCK_AUTOCONNECT. A clean solution to do this for creating new connections is missing.

It should also block changes to connection.metered and connection.zone. Ideally there would be a single flag that would block any runtime changes to only change the configuration on disk.


Additional info:
See https://github.com/linux-system-roles/network/issues/35

Comment 4 Thomas Haller 2019-07-10 17:25:43 UTC
Branch on review here: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/201

Comment 8 Thomas Haller 2019-07-23 05:56:27 UTC
> Per the Jul 22nd blocker and exception review meeting, it is requested that a justfication as to why this missed feature freeze is required.
Current review says this is not approved for exception

Comment 6

> Is there an impact to Ansible?

Yes. This extension to the API is requested for the ansible network role to implement https://github.com/linux-system-roles/network/issues/35

Comment 9 Edward Haas 2019-07-23 11:37:39 UTC
Nmstate will also benefit from this one.
The autoconnect is sometimes causing a race condition between profiles activations.

I hope that with this option, we can have a more deterministic control on the connections activation.

Comment 10 Vladimir Benes 2019-07-23 12:21:14 UTC
QE is OK with including this bug. It does sound very reasonable to have this in 8.1.

Comment 11 Thomas Haller 2019-07-25 13:01:26 UTC
(In reply to Whitney Chadwick from comment #7)
> Per the Jul 22nd blocker and exception review meeting, it is requested that
> a justfication as to why this missed feature freeze is required.
> Current review says this is not approved for exception

Regrading "why" it missed the freeze...

(same reason as https://bugzilla.redhat.com/show_bug.cgi?id=1677070#c12 )

First it missed inclusion for the devel-deadline because it wasn't ready,
and back then we decided to do this only optionally, only if there is time.
We didn't want to commit to it.

This feature missed the freeze because it was blocked by bug 1674545
which wasn't ready either. Bug 1674545 is a large, but important change compared
to this, but is has exception+ flag and is now ready to be done for rhel-8.1 (post
devel-freeze).

In comparison, this bug is a small, non-dangerous addition on top of 1674545.
The code is now ready and just waiting to get in together with bug 1674545.
Including this as well, will not destabilize the code any further. The critical
change is the other bug, which already has exception flag for good reasons.

I would not want to exclude this, because it delays that the feature becomes
usable by a minor rhel-8 release.

Comment 15 errata-xmlrpc 2019-11-05 22:29:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3623