Bug 1677331

Summary: read_history broken
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: libeditAssignee: Boris Ranto <branto>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: branto, debarshir, jeff, loganjerry
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libedit-3.1-27.20190324cvs.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-14 00:59:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
rl.c none

Description Remi Collet 2019-02-14 15:05:39 UTC
Created attachment 1534866 [details]
rl.c

See attached sources

readline: works

libedit-3.1-26.20181209cvs.fc30 works
libedit-3.1-24.20170329cvs.fc29 doesn't work



Expected:

$ ./rl
+ clean
   empty
+ fill and save it
   0: foo
   1: bar
+ clean
   empty
+ load
   0: foo
   1: bar


Actual

$ ./rl
+ clean
   empty
+ fill and save it
   0: foo
   1: bar
+ clean
   empty
+ load
   empty



P.S. discovered by PHP test suite, and failing test case
(ext/readline/tests/readline_read_history_001.phpt)

Comment 1 Remi Collet 2019-02-14 15:56:41 UTC
Addition different behavior, if you store "foo\n", the "\n" is removed by readline, not by libedit...

Comment 2 Fedora Update System 2019-05-11 23:24:55 UTC
libedit-3.1-27.20190324cvs.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e2103a77ec

Comment 3 Jerry James 2019-05-11 23:27:49 UTC
The major problem here is that the version of libedit in F30+ is not backwards compatible with the version in F29, according to abipkgdiff.  I've just updated F30 and F31 to the latest upstream release, but that does nothing for F29.  To update F29, we would have to either audit all consumers of libedit to verify that they don't use the non-backwards-compatible portions of the library, or else rebuild all consumers.  I, frankly, don't have time for either right now.  If someone else wants to undertake one of those tasks, be my guest.

Comment 4 Fedora Update System 2019-05-12 00:45:28 UTC
libedit-3.1-27.20190324cvs.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e2103a77ec

Comment 5 Fedora Update System 2019-05-14 00:59:36 UTC
libedit-3.1-27.20190324cvs.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.