Bug 1677454

Summary:	"openshift_logging_curator_run_timezone" is not implemented in CronJob template of Curator5 on v3.11
Product:	OpenShift Container Platform	Reporter:	Daein Park <dapark>
Component:	Logging	Assignee:	Jeff Cantrill <jcantril>
Status:	CLOSED ERRATA	QA Contact:	Anping Li <anli>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.11.0	CC:	anli, aos-bugs, mburke, rmeggins
Target Milestone:	---
Target Release:	3.11.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-15 05:44:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daein Park 2019-02-15 01:07:49 UTC

Description of problem:

When "playbooks/openshift-logging/config.yml" playbooks run with "openshift_logging_curator_run_timezone", 
it would not set up "CURATOR_RUN_TIMEZONE" which is configured by the variable.

Version-Release number of the following components:
rpm -q openshift-ansible

openshift-ansible-3.11.69-1.git.0.2ff281f.el7.noarch

rpm -q ansible

ansible-2.6.6-1.el7ae.noarch

ansible --version

ansible 2.6.6
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May 31 2018, 09:41:32) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

How reproducible:

It can always reproduce.

After specifing "openshift_logging_curator_run_timezone", run playbooks "deploy_clsuter.yaml" or "playbooks/openshift-logging/config.yml"

Then you can check missing "CURATOR_RUN_TIMEZONE" env variable using "oc get cronjob logging-curator -o yaml -n openshift-logging".

Steps to Reproduce:
1.
2.
3.

Actual results:

Missing "CURATOR_RUN_TIMEZONE" variables in "env" section.

Expected results:

Configured "CURATOR_RUN_TIMEZONE" as a value of "openshift_logging_curator_run_timezone".

Additional info:

Comment 3 Josef Karasek 2019-02-19 16:33:22 UTC

Between 3.10 and 3.11 we switched from custom implementation of cron to official k8s cronjob controller.
Run hour and run minute are no longer environmental variables of the pod, but are part of the cronjob configuration.
https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_logging_curator/tasks/main.yaml#L92

Kubernetes cronjob controller uses timezone of the host, which is why we don't configure it directly from curator playbook any more. As documented in https://github.com/openshift/origin-aggregated-logging/tree/master/curator#compatibility-with-openshift-37

@Daein Park, please wait for https://github.com/openshift/openshift-ansible/pull/11211 to merge and then close this bz.

Comment 4 Daein Park 2019-02-20 02:42:19 UTC

Thank you for providing the correction of this BZ @Josef,

I misunderstood to be required both "ansible playbooks" and "curator config" for configuration of run time, because the source code and logic of runtime env has been still remained now.
Let me please make clear whether or not update or remove the related source code in future for suppressing confusing. If you're remained intentionally the codes, then we would record the causes here for others.
And it also would be required to update the documentation parts.

Comment 6 Michael Burke 2019-02-23 19:20:32 UTC

Docs change PR: https://github.com/openshift/openshift-docs/pull/13758

Comment 8 Anping Li 2019-03-01 10:01:54 UTC

Verified and pass, the openshift_logging_curator_run_timezone was removed

Comment 11 Michael Burke 2019-10-04 20:07:34 UTC

Can this BZ be closed?

Comment 12 Rich Megginson 2019-10-07 14:08:02 UTC

(In reply to Michael Burke from comment #11)
> Can this BZ be closed?

This BZ has been marked as RELEASE_PENDING for months now - what's up?

Comment 13 Anping Li 2019-10-22 03:38:56 UTC

A couple of bugs in this status. Ticket files to RCM.

Comment 14 Luke Meyer 2020-05-15 05:44:06 UTC

This should have been closed due to errata shipping. Closing now.