Bug 1677515

Summary: Including 'OS::TripleO::Compute::PreNetworkConfig: /home/stack/templates/config_then_reboot.yaml ' makes overcloud deployment faild.
Product: Red Hat OpenStack Reporter: Keigo Noha <knoha>
Component: openstack-tripleo-heat-templatesAssignee: Alex Schultz <aschultz>
Status: CLOSED ERRATA QA Contact: Sasha Smolyak <ssmolyak>
Severity: medium Docs Contact:
Priority: medium    
Version: 13.0 (Queens)CC: aschultz, knoha, mburns
Target Milestone: z5Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: openstack-tripleo-heat-templates-8.2.0-3.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-14 13:55:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Keigo Noha 2019-02-15 06:45:25 UTC 
Description of problem:
Including 'OS::TripleO::Compute::PreNetworkConfig:  /home/stack/templates/config_then_reboot.yaml ' makes overcloud deployment faild.

The error message is
~~~
ERROR: Property error: : resources.Controller<nested_stack>.resources.0
  <http://XXXX/overcloud/puppet/controller-role.yaml>.
  resources.PreNetworkConfig.properties: : Unknown Property RoleParameters",
~~~

config_then_reboot.yaml doesn't have RoelParameters and ServiceNames in it.

Adding following paramters in parameters section in config_then_reboot.yaml resolves the issue.
~~~
  RoleParameters:
    type: json
    description: Parameters specific to the role
    default: {}
  ServiceNames:
    type: comma_delimited_list
    default: []
~~~

Version-Release number of selected component (if applicable):
RHOSP13 T-H-T

How reproducible:
Always

Steps to Reproduce:
1. Include config_then_reboot.yaml as OS::TripleO::<Compute/Controller>::PreNetworkConfig:.
2. Deploy overcloud

Actual results:
Overcloud deployment failed.

Expected results:
Overcloud deployment doesn't fail.
Comment 1 Alex Schultz 2019-02-18 15:02:43 UTC 
Yes it seems the default config_then_reboot.yaml we ship is out of date with the required parameters.
Comment 5 errata-xmlrpc 2019-03-14 13:55:25 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0448