Bug 1677932

Summary: /sbin/modinfo throws permission denied error [ missing u+s bits in permission after installation ] : resulting in failure to launch vmware workstation.
Product: [Fedora] Fedora Reporter: Anand <anand312>
Component: kmodAssignee: kmod development team <kmod-maint>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 28CC: anand312, jonathan, kmod-maint, skozina, ykaliuta
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-18 13:12:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Details of the steps of investigation and troubleshooting none

Description Anand 2019-02-17 00:38:25 UTC 
Description of problem:
############################

- Last week upgraded to the latest kernel update from Fedora 28 DNF repository.
- My versions are below.
   a) 4.20.8-100.fc28.x86_64  [ kernel ]
   b) kmod-25-2.fc28.x86_64 [ kmod kernel modules package ] 

Version-Release number of selected component (if applicable):
#################################################################
Fedora 28 and above are relevant versions.

How reproducible:
############################
Take a Fedora 28 system that has kernel and kmod older than the above versions and do a dnf update on them to get latest packages.


Steps to Reproduce:
############################
1. As a non root user run this on any linux kernel module 
   /sbin/modinfo vmmon [ or any other kernel module that suits you ]

2. You get permission deined error. This stops all users from running the vmware 
   products GUI [ particularly vmware workstation ].

3. I had to do the below to fix this : sudo chmod u+s /sbin/modinfo then it started to provide module info for non root users and started working fine.

Actual results:
############################
- The reason i am flagging this is so that these permissions can be applied which rpm package is getting installed itself [ so expect to see this fix in the installer post script ? ]. Also before this i have done atleast 2-3 upgrades of kernel and kmod without any issues post upgrade so i am not sure if it is specific issue to this version of kmod only [ kmod-25-2.fc28.x86_64 ]

Expected results: 
############################
Expect end users [ non root ] to be able to get kernel module info via /sbin/modinfo

Additional info: 
############################
You can directly contact me at : anand312 / anand.kulkarni.sg for more information if you need anything else 
from me.
Comment 1 Anand 2019-02-17 01:22:57 UTC 
Created attachment 1535596 [details]
Details of the steps of investigation and troubleshooting
Comment 2 Yauheni Kaliuta 2019-02-18 13:12:37 UTC 
I do not see any reason for SUID bit on kmod. The module must be readable.

Moreover, works fine for me (on F29):

% modinfo -k 4.20.8-200.fc29.x86_64 vfat
filename:       /lib/modules/4.20.8-200.fc29.x86_64/kernel/fs/fat/vfat.ko.xz
author:         Gordon Chaffee
description:    VFAT filesystem support