Bug 1678623 (strip-nondeterminism)
| Summary: | Review Request: strip-nondeterminism - File non-deterministic information stripper | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dridi Boukelmoune <dridi.boukelmoune> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review, perl-devel, ppisar, sergio |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-23 12:48:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Dridi Boukelmoune
2019-02-19 09:00:07 UTC
Taking this review. It would be nice if we support epel 7 at least, I got this error [1] complete logs [2] Thanks [1] BUILDSTDERR: Installed (but unpackaged) file(s) found: BUILDSTDERR: /usr/lib64/perl5/vendor_perl/auto/File/StripNondeterminism/.packlist [2] https://copr-be.cloud.fedoraproject.org/results/sergiomb/debs/epel-7-x86_64/00860413-strip-nondeterminism/ https://copr-be.cloud.fedoraproject.org/results/sergiomb/debs/epel-7-x86_64/00860413-strip-nondeterminism/build.log.gz (In reply to Sergio Monteiro Basto from comment #2) > BUILDSTDERR: Installed (but unpackaged) file(s) found: > BUILDSTDERR: > /usr/lib64/perl5/vendor_perl/auto/File/StripNondeterminism/.packlist > See <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker>. I.e. if you use NO_PACKLIST=1, you have to buil-require perl(ExtUtils::MakeMaker) >= 6.76. I'm ok with epel7, I would have objected to maintain it for epel6 myself :) And the packlist question is exactly why I asked for perl-experienced co-maintainers for this package, sbuild and apt. I can dig that kind of problems but it will take me much more time when the midden hits the windmill. Neal seems interested in reviewing this package. Thus only few notes from me: The URL value point to an umbrella project, not the the strip-nondeterminism itself. I'd rather use <https://salsa.debian.org/reproducible-builds/strip-nondeterminism> as the URL value. The Makefile.PL has some dependencies you missed. Please build-require "perl(strict)" and "perl(warnings)". The perl-File-StripNondeterminism subpackage delivers Perl modules into a standard Perl look-up path. That means the subpackage must run-require perl(:MODULE_COPMAT...). See <https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/#_versioned_module_compat_requires> for the specific spec code to use. The perl-File-StripNondeterminism package must own the File subdirectory. Use "%{perl_vendorlib}/*" instead of "%{perl_vendorlib}/File/*" in the %files sections. You should execute tests. Add %check section with "make test" and build-require "make" and all the Perl modules used when running the tests (e.g. "perl(Test::More)". Don't forget the tests execute some scripts, e.g. bin/strip-nondeterminism, so you also need build-require their dependencies. We have a "tangerine" tool that can help you to scan the files for the used Perl modules. @Petr, I'm happy to hand this off to you, as I only grabbed it because he seemed to be asking for reviewers. An expert is always better. :) Ok. Dridi, please update the spec file according to above mentioned advice and notify me here after doing so. I will then resume the full-featured formal review. Dridi, you need update strip-nondeterminism.spec according to above mentioned, to continue the review , until Peter approve this package . Hello Sergio and Petr, I have been away for a couple weeks but now that I am back I'm planning to make progress on this review request and a bunch of others (both as reviewer or submitter). Thank you for the initial review, I will try to be more reactive and update the spec and SPRM soon. Apologies for the non-responsiveness until now. Dridi, can I take this review , i.e. do a new review and close this one ? Thanks, Dridi, if you don't write that you want continue in this review, I will close it as a dead one. Apologies for the long silence, I'm barely keeping my Fedora commitments afloat these days. Feel free to either take over or close this ticket. |