Bug 1678857
Summary: | Satellite throws an ISE when trying to clone a channel if the org does not have software entitlements to the parent channel | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Satellite 5 | Reporter: | Marcelo Moreira de Mello <mmello> | ||||
Component: | WebUI | Assignee: | Michael Mráka <mmraka> | ||||
Status: | CLOSED ERRATA | QA Contact: | Red Hat Satellite QA List <satqe-list> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 580 | CC: | mmello, nsamant, rdrazny, risantam, tlestach | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Fixed In Version: | spacewalk-java-2.5.14-131-sat | Doc Type: | If docs needed, set a value | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2019-06-19 18:11:14 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Marcelo Moreira de Mello
2019-02-19 18:45:10 UTC
*** Bug 1678856 has been marked as a duplicate of this bug. *** spacewalk-java-2.5.14-128.el6sat.noarch also presents the issue satellite/java/code/src/com/redhat/rhn/frontend/action/channel/manage/CloneChannelAction.java 99 // add all children >>100 for (ChannelTreeNode channel : channelTree) { 101 if (!subscribableCids.contains(channel.getId()) || channel.isParent()) { 102 continue; 103 } 104 nameToId.put(channel.getName(), channel.getId()); 105 parentToChildren.get(channel.getParentId()).add(channel.getName()); 106 } 107 So the SQL returns the data but the getParentId() via hibernate explodes.. See also bug 1558684 Fixed in spacewalk git by commit 76542e1f4e0c4d2994de73e3aec861308470f772 1678857 - show an error message when parent channel is not available Backported to SATELLITE-5.8 as commit 0c7853aa9aa65f4020ec97e6b7a1d5fb9fd5c28e 1678857 - show an error message when parent channel is not available Created attachment 1574265 [details]
Error message with multiple child channels without parent entitlement
Reproduced the issue with spacewalk-java-2.5.14-129 using the reproducer from the initial report. After the update to spacewalk-java-2.5.14-130-sat the ISE is gone, but the fix doesn't work quite correctly. When there is more than one case of child channel with no entitlement for its parent channel in the org, the error message "multiplies". I have assigned three child channels without parents to the Testorg. See the attached screenshot for the resulting error message.
Fixed in upstream spacewalk git by commit 92355d387585473be5b2e0d2030e463e7431d22c 1678857 - show all errors at once Backported to SATELLITE-5.8 as commit 632f32bed8d5d4ec071dfecb667a65fe0ad8e9c1 1678857 - show all errors at once Verified on spacewalk-java-2.5.14-131. No ISE, and there is a single error message for each child channel without an entitlement to its parent. VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:1551 |