Bug 1679110

We don’t have a settings page, or you mean the one we use for console keys?

(In reply to Michal Skrivanek from comment #1)
> We don’t have a settings page, or you mean the one we use for console keys?

I'm referring to
https://bugzilla.redhat.com/show_bug.cgi?id=1171924

With regards to toast notifications settings there have been some updates to the PF4 notification drawer and it now features settings which is exciting so we can take a closer look to see if that component fits our needs.

The documentation text flag should only be set after 'doc text' field is provided. Please provide the documentation text and set the flag to '?' again.

Here are some wireframes for a short term solution for the placement of the toast notifications: https://marvelapp.com/50f0bee When we start to transition the notification drawer over to PF4 we should revisit this again.

Created attachment 1669649 [details]
resizing details with notifications moved 375px from top

Created attachment 1669651 [details]
resizing vm screen with notifications moved 375px from top

Check the screen recordings above - this is a proof of concept implementation of following design -> https://marvelapp.com/50f0bee/screen/64413543

The behavior looks good to me for the most part. My one comment regards the placement of it, I would lower it a bit more on the page so it does not cover the main page content as much. Kind of hard to gauge however depending on if there's a super long table view or other similar situations.

Created attachment 1670896 [details]
list of notifications growing bottom-up from  bottom right corner up to 400px from top

Created attachment 1670897 [details]
plugin for triggering notifications

To trigger notification
1.  go to Compute -> Virtual Machines
2. click TEST button

To reset the counter click RESET.

It looks great to me! Nice work on it!

New toasts show up under the dismiss buttons, and the dismiss buttons track up.  Plus enough toasts and you need to scroll the entire page to see them all.  How does that work with an iframe plugin (like dashboard)?  That seems a bit awkward to me.

What about keeping the dismiss buttons at the bottom of the page, show the newest toast directly above it and letting older toasts track up the page?  That way:
  1. Newest toasts would always appear in the same place
  2. The dismiss / do not disturb buttons are in a static location
  3. The toast "notif" area can set overflow to hidden (or scroll in the y) so old toasts go away as new toasts come in (or the user needs to scroll up to see them)

> New toasts show up under the dismiss buttons, and the dismiss buttons track up.
Perhaps we can just drop the buttons altogether?
The "dismiss all" buttons feels like a workaround to cope with bursts of notifications - with the new approach it should not be a problem any more.
"Do not disturb" button functionality could be part of user config.

> enough toasts and you need to scroll the entire page to see them all
Hopefully overflow will be a rare exceptional case - it is there to cope with bursts of notifications.
User is still free to review all notifications - we don't discard them silently(however the usual time out still applies)

> How does that work with an iframe plugin (like dashboard)?
When overflow occurs the page grows as other pages - below the dashboard white space appears (different colour then dashboard background)

> What about keeping the dismiss buttons at the bottom of the page
This is the preferred solution, however we need a better way of handling overflow.
Hiding blocks access to some information. Scrolling only the notification container may cause usability issues on smaller screens (double scrollbars etc).

>  Newest toasts would always appear in the same place
IMHO more natural approach is to display newest on top. Ideally this should be part of user configuration.

Triggering constant flow of notifications:
0. assumption - attached 'test' plug-in is present(will work with any other plug-in too)
1. open console in dev tools
2. paste: 
var globalCounter=0; setInterval(function() {window.top.pluginApi('test').showToast("success", "Test no " + (++globalCounter))}, 500);

Created attachment 1672612 [details]
resizing details with notifications reaching max 400px from top

Created attachment 1672613 [details]
list of notifications growing bottom-up from  bottom right corner up to 400px from top (buttons below notifications)

we're only going to move notifications to bottom right corner at this point

This bug is in modified state and targeted to 4.4.1. Can we re-target to 4.4.0 and move to QE?

(In reply to Sandro Bonazzola from comment #19)
> This bug is in modified state and targeted to 4.4.1. Can we re-target to
> 4.4.0 and move to QE?

Sure, done

Verified in 
ovirt-engine-4.4.0-0.31.master.el8ev.noarch
ovirt-engine-webadmin-portal-4.4.0-0.31.master.el8ev.noarch

Verified behavior (as demostrated in attachment 1672613 [details] and attachment 1672612 [details]):
- notifications are now shown in the bottom right corner
- multiple notifications grow bottom-up (the latest one is always on top of the list)
- with a larger number of notifications potentially reaching less than 400px from the top of the page,
  they overflow below the visible area (the page will grow) and horizontal scrollbar appears;
  Dismiss All & DnD button panel stays in place in this situation

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3247