Bug 1679213

Summary:	yum-config-manager --enable/--disable without arguments is ambiguous
Product:	Red Hat Enterprise Linux 8	Reporter:	Karel Srot <ksrot>
Component:	dnf-plugins-core	Assignee:	Pavla Kratochvilova <pkratoch>
Status:	CLOSED ERRATA	QA Contact:	Radek Bíba <rbiba>
Severity:	low	Docs Contact:
Priority:	low
Version:	8.0	CC:	amatej, james.antill, pkratoch
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	dnf-plugins-core-4.0.12-2.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 16:47:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Karel Srot 2019-02-20 15:39:52 UTC

Description of problem:

# cat /etc/yum.repos.d/bz1151154repo*
[bz1151154repoA]
name=My Local Repo bz1151154repoA
baseurl=file:///tmp/tmp.7fxA6gpJvW/bz1151154repoA/
enabled=0
gpgcheck=0
[bz1151154repoB]
name=My Local Repo bz1151154repoB
baseurl=file:///tmp/tmp.7fxA6gpJvW/bz1151154repoB/
enabled=0
gpgcheck=0

# yum-config-manager --enable
Updating Subscription Management repositories.
Unable to read consumer identity
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Error: Trying to enable already enabled repos.

# cat /etc/yum.repos.d/bz1151154repo*
[bz1151154repoA]
name=My Local Repo bz1151154repoA
baseurl=file:///tmp/tmp.kESYbvMVMs/bz1151154repoA/
enabled=0
gpgcheck=0
[bz1151154repoB]
name=My Local Repo bz1151154repoB
baseurl=file:///tmp/tmp.kESYbvMVMs/bz1151154repoB/
enabled=0
gpgcheck=0


# rpm -q dnf-utils
dnf-utils-4.0.2.2-3.el8.noarch

Comment 1 Pavla Kratochvilova 2019-09-23 11:03:07 UTC

Karel, can you please clarify, what did you mean by "ambiguous" in the summary? I think the message is not ambiguous, but plainly wrong, because dnf is not trying to enable any repository.

If the above is correct, I propose the following acceptance criteria:

AC: "yum-config-manager --enable" without arguments outputs the same as "yum-config-manager --disable", i.e. empty stderr and stdout.

Comment 2 Karel Srot 2019-09-23 11:17:00 UTC

Hi,
I was complaining on the message "Error: Trying to enable already enabled repos." while not having any repository enabled.

How much is running "yum-config-manager --enable" correct? You AC is probably sane assuming the RFE 1706384 won't be implemented.

Comment 3 Pavla Kratochvilova 2019-09-24 17:19:43 UTC

> I was complaining on the message "Error: Trying to enable already enabled repos." while not having any repository enabled.

All right, thanks.

> How much is running "yum-config-manager --enable" correct?

The old yum-config-manager exited with 0 when run with "--enable" without other arguments, so I wouldn't change that.

Comment 6 Pavla Kratochvilova 2020-01-03 13:25:30 UTC

PR: https://github.com/rpm-software-management/dnf-plugins-core/pull/377
Tests: https://github.com/rpm-software-management/ci-dnf-stack/pull/749

Comment 13 errata-xmlrpc 2020-04-28 16:47:40 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1823