Bug 1679455
| Summary: | Feature: Support new Apple ][ emulator formats and update existing 2IMG format | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Greg Wildman <greg> | ||||
| Component: | file | Assignee: | Kamil Dudka <kdudka> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | low | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 29 | CC: | jkaluza, kdudka, macermak, odubaj, svashisht | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | file-5.36-2.fc31 file-5.36-2.fc30 file-5.34-13.fc29 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-03-03 02:47:13 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Thank you for working on this! Could you please send your patch to file's upstream for review via file mailing-list? Alternatively, I could propose the change to file's upstream on your behalf... Yes I will do that. For a long while I could not get a connection to the mailman interface or bugs page. Of course when I checked again today it's up :) -- Greg Both the upstream bug tracker and mailing-list at gw.com were dead for very long time but they were moved to astron.com not so long ago: https://mailman.astron.com/pipermail/file/2019-February/000067.html upstream commits: https://github.com/file/file/commit/FILE5_36-29-g640752ca https://github.com/file/file/commit/FILE5_36-30-g4c41a4b6 Thanks, you can close this ticket. downstream commits: https://src.fedoraproject.org/rpms/file/c/04857142 https://src.fedoraproject.org/rpms/file/c/9a2a31e4 file-5.34-13.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-18b5655c9f file-5.34-13.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-18b5655c9f file-5.34-13.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1536913 [details] Apple ][ Emulators magic file patch I have updated my magic for the file command to cater for the latest Apple ][ emulator file formats. I would like to get them added to file for future versions. I also fixed up the current 2IMG magic and added all the creator strings I could find. 2IMG Examples: --------------- Aaargh!.2mg: Apple ][ 2IMG Disk Image, Revival for Windows, ProDOS sector order, 1600 Blocks Arkanoid II.2mg: Apple ][ 2IMG Disk Image, Revival for Windows, ProDOS sector order, 1600 Blocks Lode Runner Revisited.2mg: Apple ][ 2IMG Disk Image, Sweet 16, ProDOS sector order, 1600 Blocks One Arm Battle.2mg: Apple ][ 2IMG Disk Image, Sweet 16, ProDOS sector order, 1600 Blocks Pitch-Dark-20180721.2mg: Apple ][ 2IMG Disk Image, CiderPress, ProDOS sector order, 65535 Blocks ProDOS32.2mg: Apple ][ 2IMG Disk Image, CiderPress, ProDOS sector order, 65535 Blocks RastanA.2mg: Apple ][ 2IMG Disk Image, Revival for Windows, ProDOS sector order, 1600 Blocks RastanB.2mg: Apple ][ 2IMG Disk Image, Revival for Windows, ProDOS sector order, 1600 Blocks Space Shark.2mg: Apple ][ 2IMG Disk Image, XGS, ProDOS sector order, 1600 Blocks Disk images, DOS3 and ProDOS: ------------------------------ Apple ProFile Backup II.dsk: Apple ProDOS Image, Volume /BACKUP2.DISK, 280 Blocks Apple ProFile - Side 1.dsk: Apple Pascal Image, Volume PPMSTAR:, 280 Blocks, 1 Files Apple ProFile - Side 2.dsk: Apple Pascal Image, Volume PPMPROG:, 280 Blocks, 11 Files AROS.dsk: Apple DOS 3.3 Image, Volume 1, 35 Tracks, 16 Sectors, 256 bytes per sector Beneath Apple DOS.dsk: Apple DOS 3.3 Image, Volume 254, 35 Tracks, 16 Sectors, 256 bytes per sector BEZARE_hr.dsk: Apple DOS 3.2 Image, Volume 254, 35 Tracks, 16 Sectors, 256 bytes per sector DiskMaker8v1.1.dsk: Apple ProDOS Image, Volume /DM8, 280 Blocks FSM3.po: Apple ProDOS Image, Volume /PASSPORT, 280 Blocks GENIUS1_A2_Rel17.dsk: Apple DOS 3.3 Image, Volume 254, 35 Tracks, 16 Sectors, 256 bytes per sector GENIUS2_A2_Rel17.dsk: Apple DOS 3.3 Image, Volume 254, 35 Tracks, 16 Sectors, 256 bytes per sector ip65.dsk: Apple ProDOS Image, Volume /PRODOS.2.4.1, 280 Blocks KART.24.dsk: Apple DOS 3.3 Image, Volume 254, 35 Tracks, 16 Sectors, 256 bytes per sector Marinetti3.0b9.po: Apple ProDOS Image, Volume /MARINETTI3.0B9, 1600 Blocks Star Trek: First Contact 2.1.po: Apple ProDOS Image, Volume /STFC, 1600 Blocks Virtual2.po: Apple ProDOS Image, Volume /VIRTUAL, 1600 Blocks Virtual.po: Apple ProDOS Image, Volume /VIRTUAL, 1600 Blocks WOZ 1.0: -------- Aquatron.woz: Apple ][ WOZ 1.0 Disk Image, 5.25 inch, cross track synchronized, Applesauce v1.0.2 Hard Hat Mack.woz: Apple ][ WOZ 1.0 Disk Image, 5.25 inch, write protected, cross track synchronized, Applesauce v1.0.1 Paperboy.woz: Apple ][ WOZ 1.0 Disk Image, 5.25 inch, write protected, cross track synchronized, Applesauce v1.0.2 Pool v1.5.woz: Apple ][ WOZ 1.0 Disk Image, 5.25 inch, write protected, cross track synchronized, Applesauce v1.0.1 Snack Attack.woz: Apple ][ WOZ 1.0 Disk Image, 5.25 inch, cross track synchronized, Applesauce v1.0.1 WOZ 2.0: -------- Captain Goodnight side A.woz: Apple ][ WOZ 2.0 Disk Image, 5.25 inch, cross track synchronized, Passport.py by 4am (2019-02-02) Captain Goodnight side B.woz: Apple ][ WOZ 2.0 Disk Image, 5.25 inch, cross track synchronized, Passport.py by 4am (2019-02-02) I have attached my patch that builds against file-5.34-11.fc29.x86_64 using mock. Many thanks, -- Greg