Bug 1679528

Summary:	Live migration fail with unsafe error when GPFS is used as shared filesystem
Product:	[Community] Virtualization Tools	Reporter:	dmichelotto <diego.michelotto>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	diego.michelotto, hannsj_uhl, libvirt-maint, pkrempa, tburke
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-26 10:43:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1690702, 1698133, 1710728

Description dmichelotto 2019-02-21 10:58:56 UTC

Description of problem:

Live-migration fail with message "error: Unsafe migration: Migration without shared storage is unsafe" when IBM GPFS (Spectrum Scale) is used as shared file system.


Version-Release number of selected component: 4.5.0-10.el7_6.3.x86_64


How reproducible:

Install 2 nodes CentOS 7.6 with last release of libvirt

Install and mount on both nodes GPFS shared file system.

On first node create a vm with disk type file and source file on shared filesystem.

Live migrate the vm on second node.


Steps to Reproduce:
1. yum install libvirtd
2. virsh create vm.xml
3. virsh migrate --live vm  qemu+ssh://second.node/system

Actual results:
error: Unsafe migration: Migration without shared storage is unsafe

Expected results:
no error

Additional info:
If I use the option --unsafe the live-migration works fine. But it isn't the expected behavior.

This impact with our OpenStack environment base con Rocky release

Comment 1 dmichelotto 2019-02-25 08:53:37 UTC

I have just summited 2 patches:

1- from upstream code 
2- from CentOS srpm for 4.5.0 version

The code was successufully compiled and tested in both cases.

I can't see the submitted patches in the list archive, probably the e-mails must be moderated.

For us fixing this bug it's very urgent.

Comment 2 dmichelotto 2019-02-25 18:20:11 UTC

Subitted patch https://www.redhat.com/archives/libvir-list/2019-February/msg01428.html

Comment 3 Peter Krempa 2019-02-26 10:43:05 UTC

The patch was pushed upstream:

commit d163b940a73a0d6b8277a4bccef2b60936933cf0
Author: Diego Michelotto <diego.michelotto.it>
Date:   Mon Feb 25 19:19:03 2019 +0100

    virfile: added GPFS as shared fs
    
    Added GPFS as shared file system recognized during live migration
    security checks.
    
    GPFS is 'IBM General Parallel File System' also called
    'IBM Spectrum Scale'
    
    BUG: https://bugzilla.redhat.com/show_bug.cgi?id=1679528
    
    Signed-off-by: Diego Michelotto <diego.michelotto.it>
    Signed-off-by: Peter Krempa <pkrempa>